From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: "Edward Peng." <edward_peng@dlink.com.tw>
Cc: linux-kernel@vger.kernel.org
Subject: [BUG] in drivers/net/dl2k.h
Date: Tue, 28 Jan 2003 16:31:55 +0100 [thread overview]
Message-ID: <20030128153155.GA10685@wohnheim.fh-wedel.de> (raw)
Hi!
The patch below should be enough to verify the bug and create a proper
fix, I hope.
Jörn
--
If you're willing to restrict the flexibility of your approach,
you can almost always do something better.
-- John Carmack
diff -Naur linux-2.4.21-pre3-ac4/drivers/net/dl2k.c scratch/drivers/net/dl2k.c
--- linux-2.4.21-pre3-ac4/drivers/net/dl2k.c Fri Jan 24 15:25:37 2003
+++ scratch/drivers/net/dl2k.c Tue Jan 28 15:45:02 2003
@@ -1743,6 +1743,8 @@
anar.image = mii_read (dev, phy_addr, MII_ANAR);
anar.bits.half_duplex =
esr.bits.media_1000BT_HD | esr.bits.media_1000BX_HD;
+ /* BUG: esr.bits.media_1000BT_FD is uninitialized.
+ * see sl2k.h */
anar.bits.full_duplex =
esr.bits.media_1000BT_FD | esr.bits.media_1000BX_FD;
anar.bits.pause = 1;
diff -Naur linux-2.4.21-pre3-ac4/drivers/net/dl2k.h scratch/drivers/net/dl2k.h
--- linux-2.4.21-pre3-ac4/drivers/net/dl2k.h Fri Jan 24 15:25:37 2003
+++ scratch/drivers/net/dl2k.h Tue Jan 28 15:46:33 2003
@@ -513,6 +513,8 @@
u16 image;
struct {
u16 _bit_11_0:12; // bit 11:0
+ /* BUG: ":2" should be ":1", if this is really only bit 12.
+ * This should cause the bug in dl2k.c */
u16 media_1000BT_HD:2; // bit 12
u16 media_1000BT_FD:1; // bit 13
u16 media_1000BX_HD:1; // bit 14
reply other threads:[~2003-01-28 15:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030128153155.GA10685@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=edward_peng@dlink.com.tw \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®