mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: Alan Cox <alan@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Linux 2.4.21pre4-ac1
Date: Fri, 31 Jan 2003 21:21:06 +0100	[thread overview]
Message-ID: <20030131202105.GF21599@fs.tum.de> (raw)
In-Reply-To: <200301311430.h0VEUKr31316@devserv.devel.redhat.com>

On Fri, Jan 31, 2003 at 09:30:20AM -0500, Alan Cox wrote:

>...
> Linux 2.4.21pre4-ac1
>...
> o	Clean up radio_cadet locking and other bugs	(me)
>...

This causes the following compile error:

<--  snip  -->

...
gcc -D__KERNEL__ -I/home/bunk/linux/kernel-2.4/linux-2.4.20-ac/include 
-Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing 
-fno-common -pipe -mpreferred-stack-boundary=2 -march=k6   -nostdinc 
-iwithprefix include -DKBUILD_BASENAME=radio_cadet  -c -o radio-cadet.o 
radio-cadet.c
radio-cadet.c: In function `cadet_init':
radio-cadet.c:561: `cadet_lock' undeclared (first use in this function)
radio-cadet.c:561: (Each undeclared identifier is reported only once
radio-cadet.c:561: for each function it appears in.)
make[4]: *** [radio-cadet.o] Error 1
make[4]: Leaving directory `/home/bunk/linux/kernel-2.4/linux-2.4.20-ac/drivers/media/radio'

<--  snip  -->

It seems the following was intended?

--- linux-2.4.20-ac/drivers/media/radio/radio-cadet.c.old	2003-01-31 21:04:17.000000000 +0100
+++ linux-2.4.20-ac/drivers/media/radio/radio-cadet.c	2003-01-31 21:04:34.000000000 +0100
@@ -558,7 +558,7 @@
 static int __init cadet_init(void)
 {
 
-	spin_lock_init(&cadet_lock);
+	spin_lock_init(&cadet_io_lock);
 	
 	/*
 	 *	If a probe was requested then probe ISAPnP first (safest)



cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


      parent reply	other threads:[~2003-01-31 20:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-31 14:30 Alan Cox
2003-01-31 15:58 ` DervishD
2003-01-31 17:07 ` sched_runqueue.h missing: 2.4.21pre4-ac1 Mikael Johansson
2003-01-31 20:21 ` Adrian Bunk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030131202105.GF21599@fs.tum.de \
    --to=bunk@fs.tum.de \
    --cc=alan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome