From: shaheed <srhaque@iee.org>
To: Andries.Brouwer@cwi.nl
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NFS dev_t fixes
Date: Sun, 2 Feb 2003 14:53:06 +0000 [thread overview]
Message-ID: <200302021453.06531.srhaque@iee.org> (raw)
Andries,
Just a thought...did you intend to use two slightly different types for
major/minor? You say in nfs3xdr.c:
xdr_decode_fattr(u32 *p, struct nfs_fattr *fattr)
{
...
unsigned int type, major, minor;
...
major = ntohl(*p++);
minor = ntohl(*p++);
and later on in nfs4xdr.c:
uint32_t major, minor;
...
READ32(major);
READ32(minor);
I wonder if the real cause here is the different coding conventions of the two
modules...
HTH, Shaheed
next reply other threads:[~2003-02-02 14:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-02 14:53 shaheed [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-02-02 15:01 Andries.Brouwer
2003-02-02 0:38 Andries.Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200302021453.06531.srhaque@iee.org \
--to=srhaque@iee.org \
--cc=Andries.Brouwer@cwi.nl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome