mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [patch] Update of the input subsystem - 37 csets
Date: Thu, 6 Feb 2003 13:49:39 +0000	[thread overview]
Message-ID: <20030206134939.A9732@infradead.org> (raw)
In-Reply-To: <20030206141352.A10182@ucw.cz>; from vojtech@suse.cz on Thu, Feb 06, 2003 at 02:13:52PM +0100

  * Some laptops take the 789uiojklm,. keys as number pad when NumLock is on.
  * This seems a good reason to start with NumLock off.
  */
+#ifndef CONFIG_X86_PC9800
 #define KBD_DEFLEDS 0
+#else
+#define KBD_DEFLEDS (1 << VC_NUMLOCK)
+#endif
 #endif

This ifdef is the wrong way around.
But having something like

#ifndef KBD_DEFLEDS
#define KBD_DEFLEDS 0
#endif

and the PC98-specific stuff in a asm header sounds like a much better plan.
 
 
--- bk/include/linux/serio.h	Thu Feb  6 13:10:36 2003
+++ bk+input/include/linux/serio.h	Thu Feb  6 13:21:56 2003
@@ -10,10 +10,13 @@
  */
 
 #include <linux/ioctl.h>
-#include <linux/list.h>
 
 #define SPIOCSTYPE	_IOW('q', 0x01, unsigned long)
 
+#ifdef __KERNEL__
+
+#include <linux/list.h>


Don't add more #ifdef __KERNEL__ - the kernel headers aren't supposed
to be included from userspace.


  reply	other threads:[~2003-02-06 13:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-06 13:13 Vojtech Pavlik
2003-02-06 13:49 ` Christoph Hellwig [this message]
2003-02-06 14:10   ` Vojtech Pavlik
2003-02-06 14:14     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030206134939.A9732@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®