From: Rusty Russell <rusty@rustcorp.com.au>
To: Frank Davis <fdavis@si.rr.com>
Cc: R.E.Wolff@BitWizard.nl, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.59 : drivers/char/sx.c
Date: Mon, 10 Feb 2003 11:30:29 +1100 [thread overview]
Message-ID: <20030210014642.673722C2B7@lists.samba.org> (raw)
In-Reply-To: Your message of "Fri, 07 Feb 2003 12:21:46 CDT." <Pine.LNX.4.44.0302071219540.6917-100000@master>
In message <Pine.LNX.4.44.0302071219540.6917-100000@master> you write:
> Hello all,
> The following patch addresses buzilla bug # 322, and removes a double
> logical issue. Please review for inclusion.
>
> Regards,
> Frank
Roger? Is this what was meant here?
Thanks,
Rusty.
> --- linux/drivers/char/sx.c.old 2003-01-16 21:22:03.000000000 -0500
> +++ linux/drivers/char/sx.c 2003-02-07 02:30:33.000000000 -0500
> @@ -522,13 +522,13 @@
>
> func_enter ();
>
> - for (i=0; i < TIMEOUT_1 > 0;i++)
> + for (i=0; ((TIMEOUT_1 > 0) && (i < TIMEOUT_1));i++)
> if ((read_sx_byte (board, offset) & mask) == correctval) {
> func_exit ();
> return 1;
> }
>
> - for (i=0; i < TIMEOUT_2 > 0;i++) {
> + for (i=0; ((TIMEOUT_2 > 0 ) && (i < TIMEOUT_2 > 0));i++) {
> if ((read_sx_byte (board, offset) & mask) == correctval) {
> func_exit ();
> return 1;
> @@ -548,13 +548,15 @@
>
> func_enter ();
>
> - for (i=0; i < TIMEOUT_1 > 0;i++)
> + for (i=0; ((TIMEOUT_1 > 0) && (i < TIMEOUT_1));i++)
> + if ((read_sx_byte (board, offset) & mask) == correctval) {
> if ((read_sx_byte (board, offset) & mask) != badval) {
> func_exit ();
> return 1;
> }
>
> - for (i=0; i < TIMEOUT_2 > 0;i++) {
> + for (i=0; ((TIMEOUT_2 > 0 ) && (i < TIMEOUT_2 > 0));i++) {
> + if ((read_sx_byte (board, offset) & mask) == correctval) {
> if ((read_sx_byte (board, offset) & mask) != badval) {
> func_exit ();
> return 1;
>
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
prev parent reply other threads:[~2003-02-10 1:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-07 17:21 Frank Davis
2003-02-10 0:30 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030210014642.673722C2B7@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=R.E.Wolff@BitWizard.nl \
--cc=fdavis@si.rr.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®