From: Mikael Pettersson <mikpe@csd.uu.se>
To: james.bottomley@steeleye.com
Cc: clem@clem.clem-digital.net, linux-kernel@vger.kernel.org
Subject: 2.5.60 3c509 & net/Space.c problem
Date: Tue, 11 Feb 2003 02:44:19 +0100 (MET) [thread overview]
Message-ID: <200302110144.CAA15199@kim.it.uu.se> (raw)
>From Linus' 2.5.60 announcement:
>James Bottomley <james.bottomley@steeleye.com>:
> o 3c509 fixes: correct MCA probing, add back ISA probe to Space.c
This is somewhat broken. patch-2.5.60 has
--- a/drivers/net/Space.c Mon Feb 10 10:39:23 2003
+++ b/drivers/net/Space.c Mon Feb 10 10:39:23 2003
@@ -224,6 +224,9 @@
#ifdef CONFIG_EL2 /* 3c503 */
{el2_probe, 0},
#endif
+#ifdef CONFIG_EL3
+ {el3_probe, 0},
+#endif
#ifdef CONFIG_HPLAN
{hp_probe, 0},
#endif
but (a) there's no declaration for el3_probe() in scope at this
point, leading to a compile error, and (b) el3_probe() is still
'static' in 3c509.c, leading to a linkage error (assuming a
declaration for el3_probe() was added to Space.c to fix (a) first)
Reverting the patch to Space.c solved the problem for me.
Why the probe list entry? Isn't the module_init() in 3c509.c enough?
/Mikael
next reply other threads:[~2003-02-11 1:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-11 1:44 Mikael Pettersson [this message]
2003-02-11 2:26 ` Andrew Morton
2003-02-12 3:52 ` Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200302110144.CAA15199@kim.it.uu.se \
--to=mikpe@csd.uu.se \
--cc=clem@clem.clem-digital.net \
--cc=james.bottomley@steeleye.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®