mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@digeo.com>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: pablo@menichini.com.ar, rusty@rustcorp.com.au,
	linux-kernel@vger.kernel.org
Subject: Re: 2.5.60: arlan.c no longer compiles
Date: Tue, 11 Feb 2003 15:08:23 -0800	[thread overview]
Message-ID: <20030211150823.0d536772.akpm@digeo.com> (raw)
In-Reply-To: <20030211164414.GN17128@fs.tum.de>

Adrian Bunk <bunk@fs.tum.de> wrote:
>
> On Mon, Feb 10, 2003 at 11:08:28AM -0800, Linus Torvalds wrote:
> >...
> > Summary of changes from v2.5.59 to v2.5.60
> > ============================================
> >...
> > Rusty Russell <rusty@rustcorp.com.au>:
> >...
> >   o Memory leak in drivers_net_arlan.c (1)
> >...
> 
> This change broke the compilation of arlan.c:
> 

 drivers/net/arlan.c |   40 ++++++++++++++++++++--------------------
 1 files changed, 20 insertions(+), 20 deletions(-)

diff -puN drivers/net/arlan.c~arlan-fix drivers/net/arlan.c
--- 25/drivers/net/arlan.c~arlan-fix	Tue Feb 11 15:03:45 2003
+++ 25-akpm/drivers/net/arlan.c	Tue Feb 11 15:07:08 2003
@@ -1124,24 +1124,6 @@ static int __init arlan_probe_everywhere
 	return -ENODEV;
 }
 
-static int __init arlan_find_devices(void)
-{
-	int m;
-	int found = 0;
-
-	ARLAN_DEBUG_ENTRY("arlan_find_devices");
-	if (mem != 0 && numDevices == 1)	/* Check a single specified location. */
-		return 1;
-	for (m =(int) phys_to_virt(0xc0000); m <=(int) phys_to_virt(0xDE000); m += 0x2000)
-	{
-		if (arlan_check_fingerprint(m) == 0)
-			found++;
-	}
-	ARLAN_DEBUG_EXIT("arlan_find_devices");
-
-	return found;
-}
-
 
 static int arlan_change_mtu(struct net_device *dev, int new_mtu)
 {
@@ -1199,7 +1181,7 @@ static int __init
 			return 0;
 		}
 		ap = dev->priv;
-		ap->config = dev->priv + sizeof(struct arlan_private);
+		ap->conf = dev->priv + sizeof(struct arlan_private);
 		ap->init_etherdev_alloc = 1;
 	} else {
 		dev = devs;
@@ -1209,7 +1191,7 @@ static int __init
 			return 0;
 		}
 		ap = dev->priv;
-		ap->config = dev->priv + sizeof(struct arlan_private);
+		ap->conf = dev->priv + sizeof(struct arlan_private);
 		memset(ap, 0, sizeof(*ap));
 	}
 
@@ -2007,6 +1989,24 @@ int __init arlan_probe(struct net_device
 
 #ifdef  MODULE
 
+static int __init arlan_find_devices(void)
+{
+	int m;
+	int found = 0;
+
+	ARLAN_DEBUG_ENTRY("arlan_find_devices");
+	if (mem != 0 && numDevices == 1)	/* Check a single specified location. */
+		return 1;
+	for (m =(int) phys_to_virt(0xc0000); m <=(int) phys_to_virt(0xDE000); m += 0x2000)
+	{
+		if (arlan_check_fingerprint(m) == 0)
+			found++;
+	}
+	ARLAN_DEBUG_EXIT("arlan_find_devices");
+
+	return found;
+}
+
 int init_module(void)
 {
 	int i = 0;

_


  reply	other threads:[~2003-02-11 22:59 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-10 19:08 Linux 2.5.60 Linus Torvalds
2003-02-10 20:41 ` Maciej Soltysiak
2003-02-10 21:06   ` Linux 2.5.60 Compile error James Lamanna
2003-02-10 21:38     ` Kevin Corry
2003-02-10 22:50       ` Muli Ben-Yehuda
2003-02-10 21:52     ` Dave Jones
2003-02-11  0:12     ` Another " Vlad@geekizoid.com
2003-02-11  5:21       ` Anthony J. Breeds-Taurima
2003-02-10 21:11   ` Linux 2.5.60 Stephen Hemminger
2003-02-10 21:25     ` James Lamanna
2003-02-10 22:54       ` Linus Torvalds
2003-02-10 20:46 ` 2.5.60: JFS no longer compiles with gcc 2.95 Adrian Bunk
2003-02-10 21:43   ` James Lamanna
2003-02-11  7:27     ` Adrian Bunk
2003-02-12 14:52       ` [PATCH - 2.5.60] " Dave Kleikamp
2003-02-12 15:04         ` Adrian Bunk
2003-02-12 15:42           ` Dave Kleikamp
2003-02-12 16:22             ` Andreas Schwab
2003-02-10 22:21 ` Linux 2.5.60 John Cherry
2003-02-11  7:08 ` Oleg Drokin
2003-02-11  7:38   ` Linus Torvalds
2003-02-12  8:11     ` Eric W. Biederman
2003-02-12 11:49       ` Jeff Dike
2003-02-13 23:25         ` Werner Almesberger
2003-02-11 15:16 ` Zephaniah E. Hull
2003-02-11 22:47   ` Andrew Morton
2003-02-11 22:54     ` Andrew Morton
2003-02-14 16:56       ` Zephaniah E. Hull
2003-02-11 16:23 ` Russell King
2003-02-11 17:06   ` Linus Torvalds
2003-02-12  2:47     ` David S. Miller
2003-02-11 16:44 ` 2.5.60: arlan.c no longer compiles Adrian Bunk
2003-02-11 23:08   ` Andrew Morton [this message]
2003-02-11 18:16 ` 2.5.60: sim710.c doesn't compile Adrian Bunk
2003-02-11 18:21   ` James Bottomley
2003-02-11 22:00 ` Linux 2.5.60 Rudmer van Dijk
2003-02-12 10:05 ` Ingo Oeser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030211150823.0d536772.akpm@digeo.com \
    --to=akpm@digeo.com \
    --cc=bunk@fs.tum.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pablo@menichini.com.ar \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome