Re: jfs breakage in 2.5.60

[Dave Kleikamp <shaggy@austin.ibm.com>]

On Tuesday 11 February 2003 14:57, Dave Jones wrote:
> Running fsx & fsstress in parallel gets a load of oopsen in the
> logs, here's the first one..
>
> 		Dave

Thanks Dave,
I think I know what the problem is here.  I tried to adapt some code I 
used at unmount for the sync_fs call, but I screwed up.  The routine is 
waiting until all the journal writes have completed but it doesn't 
anticipate (or prevent) new activity.  The code times out after a while 
because a BUG at unmount time is easier to track down than a hang.

I'll work on a real patch, but this should work in the mean time.  
(Pardon the compiler warning.)

===== fs/jfs/super.c 1.33 vs edited =====
--- 1.33/fs/jfs/super.c	Fri Jan 17 14:17:14 2003
+++ edited/fs/jfs/super.c	Tue Feb 11 15:36:25 2003
@@ -396,7 +396,6 @@
 	.write_inode	= jfs_write_inode,
 	.delete_inode	= jfs_delete_inode,
 	.put_super	= jfs_put_super,
-	.sync_fs	= jfs_sync_fs,
 	.write_super_lockfs = jfs_write_super_lockfs,
 	.unlockfs       = jfs_unlockfs,
 	.statfs		= jfs_statfs,

-- 
David Kleikamp
IBM Linux Technology Center