From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [patch] input: sunkbd.c - fix reading beyond end of keycode array [14/14]
Date: Wed, 12 Feb 2003 08:38:26 -0800 [thread overview]
Message-ID: <20030212083826.54a2b160.rddunlap@osdl.org> (raw)
In-Reply-To: <20030212120757.M1563@ucw.cz>
On Wed, 12 Feb 2003 12:07:57 +0100
Vojtech Pavlik <vojtech@suse.cz> wrote:
| diff -Nru a/drivers/input/keyboard/sunkbd.c b/drivers/input/keyboard/sunkbd.c
| --- a/drivers/input/keyboard/sunkbd.c Wed Feb 12 11:56:22 2003
| +++ b/drivers/input/keyboard/sunkbd.c Wed Feb 12 11:56:22 2003
| @@ -268,7 +268,7 @@
| sprintf(sunkbd->name, "Sun Type %d keyboard", sunkbd->type);
|
| memcpy(sunkbd->keycode, sunkbd_keycode, sizeof(sunkbd->keycode));
| - for (i = 0; i < 255; i++)
| + for (i = 0; i < 127; i++)
| set_bit(sunkbd->keycode[i], sunkbd->dev.keybit);
| clear_bit(0, sunkbd->dev.keybit);
|
If sunkbd has a valid keycode 127, that new loop test won't handle it,
so it should/could be:
| + for (i = 0; i < 128; i++)
--
~Randy
next prev parent reply other threads:[~2003-02-12 16:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-12 10:59 [patch] input: Update AT+PS/2 mouse and keyboard drivers [1/14] Vojtech Pavlik
2003-02-12 11:00 ` [patch] input: Remove include/linux/pc_keyb.h and old PS/2 code [2/14] Vojtech Pavlik
2003-02-12 11:01 ` [patch] input: Only generate rawmode warnings for keys [3/14] Vojtech Pavlik
2003-02-12 11:01 ` [patch] input: Let newly connected keyboards pickup the LED state. [4/14] Vojtech Pavlik
2003-02-12 11:02 ` [patch] input: Get rid of kbd_pt_regs [5/14] Vojtech Pavlik
2003-02-12 11:03 ` [patch] input: Support for NEC PC-9800 beeper and support for Kana Lock [6/14] Vojtech Pavlik
2003-02-12 11:03 ` [patch] input: HID update [7/14] Vojtech Pavlik
2003-02-12 11:04 ` [patch] input: joydev/mousedev update [8/14] Vojtech Pavlik
2003-02-12 11:04 ` [patch] input: Give preferential treatment to gameport at 0x201 [9/14] Vojtech Pavlik
2003-02-12 11:05 ` [patch] input: Add support for ThrustMaster ForceFeedback [10/14] Vojtech Pavlik
2003-02-12 11:06 ` [patch] input: PowerMate driver update [11/14] Vojtech Pavlik
2003-02-12 11:06 ` [patch] input: Resurrect usb_set_report for Aiptek and Wacom tablets [12/14] Vojtech Pavlik
2003-02-12 11:07 ` [patch] input: Add two new serio type #defines [13/14] Vojtech Pavlik
2003-02-12 11:07 ` [patch] input: sunkbd.c - fix reading beyond end of keycode array [14/14] Vojtech Pavlik
2003-02-12 16:38 ` Randy.Dunlap [this message]
2003-02-13 1:06 ` Vojtech Pavlik
2003-02-12 16:13 ` [patch] input: Get rid of kbd_pt_regs [5/14] James Simmons
2003-02-13 1:13 ` Vojtech Pavlik
2003-02-13 16:39 ` James Simmons
2003-02-13 16:40 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030212083826.54a2b160.rddunlap@osdl.org \
--to=rddunlap@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®