From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 12 Feb 2003 20:03:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 12 Feb 2003 20:03:57 -0500 Received: from twilight.ucw.cz ([195.39.74.230]:2755 "EHLO twilight.ucw.cz") by vger.kernel.org with ESMTP id ; Wed, 12 Feb 2003 20:03:56 -0500 Date: Thu, 13 Feb 2003 02:13:33 +0100 From: Vojtech Pavlik To: James Simmons Cc: Vojtech Pavlik , Linus Torvalds , Linux Kernel Mailing List Subject: Re: [patch] input: Get rid of kbd_pt_regs [5/14] Message-ID: <20030213021333.A6256@ucw.cz> References: <20030212120242.D1563@ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from jsimmons@infradead.org on Wed, Feb 12, 2003 at 04:13:51PM +0000 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 12, 2003 at 04:13:51PM +0000, James Simmons wrote: > One idea about kbd_pt_regs. Only one function, fn_show_ptregs, uses > kbd_pt_regs. Instaed of passing reg data around wouldn't be better to > just remove fn_show_ptregs from the FN_HANDLERS and call it independently > inside of kbd_keycode instead. I'm not sure if that's really a nicer solution. -- Vojtech Pavlik SuSE Labs