From: Olivier Galibert <galibert@pobox.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] smctr.c changes in latest BK
Date: Fri, 14 Feb 2003 04:48:18 -0500 [thread overview]
Message-ID: <20030214044818.A5658@kerberos.ncsl.nist.gov> (raw)
In-Reply-To: <Pine.LNX.4.44.0302140001160.28838-100000@gfrw1044.bocc.de>; from jochen@scram.de on Fri, Feb 14, 2003 at 12:05:24AM +0100
On Fri, Feb 14, 2003 at 12:05:24AM +0100, Jochen Friedrich wrote:
> On Thu, 13 Feb 2003, Jochen Friedrich wrote:
> > Please revert this one as it is just wrong. As already mentioned here in
> > LKML (IIRC it was Alan), the semicolon is really intended here.
> >
> > The above loop just runs until a non-zero byte is found in the MAC
> > address or all 6 bytes have been checked. A value of i=6 will then
> > indicate an all-zero MAC address.
>
> After taking a second look, i just recognized that both cases (MAC adress
> all-zero or not) are handled exactly the same (by duplicated code), so the
> whole stuff is unnecessary.
>
> The whole function just reduces to a simple copy loop:
Doesn't that mean that the original function was buggy and it should
not have copied the mac address over if one was user-provided?
OG.
next prev parent reply other threads:[~2003-02-14 9:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-13 22:46 Jochen Friedrich
2003-02-13 23:05 ` Jochen Friedrich
2003-02-13 23:34 ` Jeff Garzik
2003-02-14 9:48 ` Olivier Galibert [this message]
2003-02-14 10:15 ` Jochen Friedrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030214044818.A5658@kerberos.ncsl.nist.gov \
--to=galibert@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®