From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
To: Marc Zyngier <mzyngier@freesurf.fr>
Cc: James Bottomley <James.Bottomley@steeleye.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EISA/sysfs update
Date: Fri, 14 Feb 2003 17:32:17 +0300 [thread overview]
Message-ID: <20030214173217.A17730@jurassic.park.msu.ru> (raw)
In-Reply-To: <wrp3cmrrwuf.fsf@hina.wild-wind.fr.eu.org>; from mzyngier@freesurf.fr on Fri, Feb 14, 2003 at 11:16:24AM +0100
On Fri, Feb 14, 2003 at 11:16:24AM +0100, Marc Zyngier wrote:
> # - Add driver for i82375 PCI/EISA bridge.
I believe this driver will work for any PCI/EISA bridge without
any changes, not only for i82375. Probably we need to look for a
class code rather than a device id.
Also, to get rid of that x86-ism I'd suggest something like
i82375_root.dev = &pdev->dev;
i82375_root.dev->driver_data = &i82375_root;
- i82375_root.bus_base_addr = 0; /* Warning, this is a x86-ism */
- i82375_root.res = &ioport_resource;
+ i82375_root.res = pdev->bus->resource[0];
+ i82375_root.bus_base_addr = pdev->bus->resource[0]->start;
i82375_root.slots = EISA_MAX_SLOTS;
Without that you'll have resource conflicts on multi-hose alphas.
Otherwise, the patch looks good to me.
Ivan.
next prev parent reply other threads:[~2003-02-14 14:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-03 3:09 [PATCH] fix 3c509.c for MCA drivers James Bottomley
2003-02-08 17:25 ` Marc Zyngier
2003-02-14 10:16 ` [PATCH] EISA/sysfs update Marc Zyngier
2003-02-14 14:32 ` Ivan Kokshaysky [this message]
2003-02-14 15:32 ` Marc Zyngier
2003-02-14 16:05 ` Ivan Kokshaysky
2003-02-14 16:42 ` Marc Zyngier
2003-02-15 12:20 ` [PATCH] EISA/sysfs update, take #2 Marc Zyngier
2003-02-14 18:12 ` [PATCH] EISA/sysfs update Christoph Hellwig
2003-02-14 19:37 ` Marc Zyngier
2003-03-05 14:22 Marc Zyngier
2003-04-21 16:48 Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030214173217.A17730@jurassic.park.msu.ru \
--to=ink@jurassic.park.msu.ru \
--cc=James.Bottomley@steeleye.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mzyngier@freesurf.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®