From: Christoph Hellwig <hch@infradead.org>
To: "Martin J. Bligh" <mbligh@aracnet.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [Bug 355] New: Error when compiling SCSI drivers (Adaptec, Seagate etc.)
Date: Fri, 14 Feb 2003 18:15:35 +0000 [thread overview]
Message-ID: <20030214181535.B32737@infradead.org> (raw)
In-Reply-To: <57590000.1045237423@[10.10.2.4]>; from mbligh@aracnet.com on Fri, Feb 14, 2003 at 07:43:43AM -0800
On Fri, Feb 14, 2003 at 07:43:43AM -0800, Martin J. Bligh wrote:
> http://bugme.osdl.org/show_bug.cgi?id=355
>
> Summary: Error when compiling SCSI drivers (Adaptec, Seagate
> etc.)
> Kernel Version: 2.5.60 (- bk4)
> Status: NEW
> Severity: normal
> Owner: andmike@us.ibm.com
> Submitter: martinsteeg@t-online.de
>
>
> Software Environment: linnx Kernel 2.5.60 ( and snapshots -bk1 ... -bk4)
> Problem Description:
> In the change of linux-2.5.59 to linux-2.5.60, the struct scsi_cmnd
> was changed in that the fields host, target, lun, channel are replaced
> by fields of the device field (struct scsi_device*): host, id, lun,
> channel
> This is not reflected in several SCSI drivers, e.g. the change is not
> considered for Adaptec and Seagate SCSI controllers.
>
> Proposal to fix the Problem:
> 1. some new defines for drivers/scsi/scsi.h
> +#define SCSICMND_HOST device->host
> +#define SCSICMND_TARGET device->id
> +#define SCSICMND_LUN device->lun
> +#define SCSICMND_CHANNEL device->channel
This macro abuse will never get into mainline. Fix it to use the proper
dereferences directly, that'll work fine for older kernels aswell.
/me wonders how people get the crazy idea that cpp abuse will make code
more maintainable..
prev parent reply other threads:[~2003-02-14 18:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-14 15:43 Martin J. Bligh
2003-02-14 18:15 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030214181535.B32737@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®