mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Bob Miller <rem@osdl.org>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.5.60 2/9] Update parport class driver to new module loader API.
Date: Sat, 15 Feb 2003 11:16:42 +0000	[thread overview]
Message-ID: <20030215111642.A17769@infradead.org> (raw)
In-Reply-To: <20030214234557.GC13336@doc.pdx.osdl.net>; from rem@osdl.org on Fri, Feb 14, 2003 at 03:45:57PM -0800

On Fri, Feb 14, 2003 at 03:45:57PM -0800, Bob Miller wrote:
> -	void (*inc_use_count)(void);
> +	int (*inc_use_count)(void);
>  	void (*dec_use_count)(void);

This is broken.  You need

	struct module *owner;

here and use try_module_et/module_put before calling into the module.


  parent reply	other threads:[~2003-02-15 11:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-14 23:45 Bob Miller
2003-02-14 23:54 ` how to interactively break gdb debugging kernel over serial? David Wuertele
2003-02-16  7:14   ` george anzinger
2003-02-18 20:37     ` David Wuertele
2003-02-18 22:49       ` george anzinger
2003-02-15 11:16 ` Christoph Hellwig [this message]
2003-02-17 17:15   ` [PATCH 2.5.60 2/9] Update parport class driver to new module loader API Bob Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030215111642.A17769@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rem@osdl.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®