mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@digeo.com>
To: Jens Axboe <axboe@suse.de>, Anton Blanchard <anton@samba.org>,
	Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.kernel.org
Subject: [patch] elv_former_request reversion
Date: Sat, 15 Feb 2003 16:12:36 -0800	[thread overview]
Message-ID: <20030215161236.67ce3f24.akpm@digeo.com> (raw)


This morning's fix for elv_former_request() is causing oopses all over the
place in the IO scheduler.

Jens, remember that I did try that fix a while ago, and the same happened.

I believe it has exposed a new problem at the __make_request/attempt_front_merge
level: if attempt_front_merge() actually succeeds, the wrong request gets freed
up in elv_merged_request().

It may be best to back this change out until it can be fixed up for real.


diff -puN drivers/block/elevator.c~deadline-hack drivers/block/elevator.c
--- 25/drivers/block/elevator.c~deadline-hack	2003-02-15 15:56:56.000000000 -0800
+++ 25-akpm/drivers/block/elevator.c	2003-02-15 15:57:09.000000000 -0800
@@ -399,7 +399,7 @@ struct request *elv_former_request(reque
 	elevator_t *e = &q->elevator;
 
 	if (e->elevator_former_req_fn)
-		return e->elevator_former_req_fn(q, rq);
+		return e->elevator_latter_req_fn(q, rq);
 
 	prev = rq->queuelist.prev;
 	if (prev != &q->queue_head && prev != &rq->queuelist)

_


             reply	other threads:[~2003-02-16  0:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-16  0:12 Andrew Morton [this message]
2003-02-16  9:32 ` Jens Axboe
2003-02-16 11:59   ` Jens Axboe
2003-02-16 12:29     ` Andrew Morton
2003-02-16 12:53     ` Anton Blanchard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030215161236.67ce3f24.akpm@digeo.com \
    --to=akpm@digeo.com \
    --cc=anton@samba.org \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®