Re: [RFC] klibc for 2.5.59 bk

[Stelian Pop <stelian.pop@fr.alcove.com>]

On Tue, Feb 18, 2003 at 04:45:33AM -0500, Jeff Garzik wrote:

> >Linus, please apply.
> 
> um, please don't...

[...]
> 
> ...because
> (a) the Crusoe cflags are no longer together,
> (b) Cyrix-3 cflags are suddenly bisected by Crusoe cflags, and
> (c) you just dumped a crusoe-specific line in the middle of a bunch of 
> Via/Cyrix CPU settings.
> 
> None of those choices makes sense.  If you want to improve upon my 
> patch, I would suggest consolidating the -f/-m check above the CPU 
> cflags section, and then reference the calculated value, rather than 
> wholly duplicating the calculation.  The comment line "# The alignment 
> flags [...]" is obviously not the start of a new alignment-flags section.

Agreed, I was overzealous here...

Consolidating the -f/-m check above seems a bit overkill, especially
since we don't want the same align options for all architectures.

Maybe removing the comment is the simplest improvement on your 
patch then. Not a big improvement however :)

Stelian.

===== arch/i386/Makefile 1.44 vs edited =====
--- 1.44/arch/i386/Makefile	Fri Feb  7 19:59:54 2003
+++ edited/arch/i386/Makefile	Tue Feb 18 10:51:40 2003
@@ -39,12 +39,12 @@
 cflags-$(CONFIG_MK6)		+= $(call check_gcc,-march=k6,-march=i586)
 cflags-$(CONFIG_MK7)		+= $(call check_gcc,-march=athlon,-march=i686 -malign-functions=4)
 cflags-$(CONFIG_MK8)		+= $(call check_gcc,-march=k8,$(call check_gcc,-march=athlon,-march=i686 -malign-functions=4))
-cflags-$(CONFIG_MCRUSOE)	+= -march=i686 -malign-functions=0 -malign-jumps=0 -malign-loops=0
+cflags-$(CONFIG_MCRUSOE)	+= -march=i686
+cflags-$(CONFIG_MCRUSOE)	+= $(call check_gcc,-falign-functions=0 -falign-jumps=0 -falign-loops=0,-malign-functions=0 -malign-jumps=0 -malign-loops=0)
 cflags-$(CONFIG_MWINCHIPC6)	+= $(call check_gcc,-march=winchip-c6,-march=i586)
 cflags-$(CONFIG_MWINCHIP2)	+= $(call check_gcc,-march=winchip2,-march=i586)
 cflags-$(CONFIG_MWINCHIP3D)	+= -march=i586
 cflags-$(CONFIG_MCYRIXIII)	+= $(call check_gcc,-march=c3,-march=i486)
-# The alignment flags change with gcc 3.2
 cflags-$(CONFIG_MCYRIXIII)	+= $(call check_gcc,-falign-functions=0 -falign-jumps=0 -falign-loops=0,-malign-functions=0 -malign-jumps=0 -malign-loops=0)
 cflags-$(CONFIG_MVIAC3_2)	+= $(call check_gcc,-march=c3-2,-march=i686)
 

-- 
Stelian Pop <stelian.pop@fr.alcove.com>
Alcove - http://www.alcove.com