From: Christoph Hellwig <hch@infradead.org>
To: Osamu Tomita <tomita@cinet.co.jp>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (6/21) FS & partiton
Date: Mon, 24 Feb 2003 14:16:13 +0000 [thread overview]
Message-ID: <20030224141613.A6064@infradead.org> (raw)
In-Reply-To: <20030224140539.GB1115@yuzuki.cinet.co.jp>; from tomita@cinet.co.jp on Mon, Feb 24, 2003 at 11:05:39PM +0900
On Mon, Feb 24, 2003 at 11:05:39PM +0900, Osamu Tomita wrote:
> --- linux/fs/fat/inode.c 2003-01-02 12:21:53.000000000 +0900
> +++ linux98/fs/fat/inode.c 2003-02-24 11:30:10.000000000 +0900
> @@ -939,7 +939,8 @@
> error = first;
> goto out_fail;
> }
> - if (FAT_FIRST_ENT(sb, media) != first) {
> + if (FAT_FIRST_ENT(sb, media) != first
> + && (media != 0xf8 || FAT_FIRST_ENT(sb, 0xfe) != first)) {
Maybe add a small comment here describing it's needed for PC98 dos?
BTW: Linux codingstyle sais it should be written as
if (FAT_FIRST_ENT(sb, media) != first &&
(media != 0xf8 || FAT_FIRST_ENT(sb, 0xfe) != first)) {
Also please split this patch up into one to the fat file system
and one to the partition code.
Otherwise this patch looks nice to me.
next prev parent reply other threads:[~2003-02-24 14:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-23 9:21 [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (0/21) summary Osamu Tomita
2003-02-23 9:34 ` [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (1/21) ALSA Osamu Tomita
2003-02-23 9:36 ` [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (2/21) APM Osamu Tomita
2003-02-23 9:38 ` [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (3/21) console Osamu Tomita
2003-02-23 9:40 ` [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (4/21) Misc core Osamu Tomita
2003-02-23 9:41 ` [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (5/21) DMA Osamu Tomita
2003-02-23 9:43 ` [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (6/21) FS & partiton Osamu Tomita
2003-02-23 10:29 ` Christoph Hellwig
2003-02-23 10:45 ` Osamu Tomita
2003-02-24 14:05 ` Osamu Tomita
2003-02-24 14:16 ` Christoph Hellwig [this message]
2003-02-23 10:47 ` John Bradford
2003-02-23 9:44 ` [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (7/21) IDE Osamu Tomita
2003-02-23 9:46 ` [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (8/21) kanji Osamu Tomita
2003-02-23 9:47 ` [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (9/21) kconfig Osamu Tomita
2003-02-23 9:48 ` [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (10/21) NIC Osamu Tomita
2003-02-23 9:50 ` [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (11/21) parport Osamu Tomita
2003-02-23 9:51 ` [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (12/21) PCI Osamu Tomita
2003-02-23 9:52 ` [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (13/21) PCMCIA Osamu Tomita
2003-02-23 9:53 ` [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (14/21) PNP Osamu Tomita
2003-02-23 9:54 ` [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (15/21) RTC Osamu Tomita
2003-02-23 9:55 ` [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (16/21) SCSI Osamu Tomita
2003-02-23 10:52 ` Christoph Hellwig
2003-02-23 9:56 ` [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (17/21) serial Osamu Tomita
2003-02-23 9:57 ` [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (18/21) setup Osamu Tomita
2003-02-23 9:58 ` [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (19/21) SMP Osamu Tomita
2003-02-23 9:59 ` [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (20/21) timer Osamu Tomita
2003-02-23 10:00 ` [PATCH] PC-9800 subarch. support for 2.5.62-AC1 (21/21) traps Osamu Tomita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030224141613.A6064@infradead.org \
--to=hch@infradead.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=tomita@cinet.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®