mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Thornber <joe@fib011235813.fsnet.co.uk>
To: Linus Torvalds <torvalds@transmeta.com>,
	Linux Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH 4/8] dm: deregister the misc device before removing /dev/mapper
Date: Wed, 26 Feb 2003 17:10:18 +0000	[thread overview]
Message-ID: <20030226171018.GD8369@fib011235813.fsnet.co.uk> (raw)
In-Reply-To: <20030226170537.GA8289@fib011235813.fsnet.co.uk>

Fix problem with devfs when unloading the dm module.

dm-ioctl.c: deregister the misc device, and its associated symlink
*before* removing the /dev/mapper dir.  [Alasdair Kergon]

--- diff/drivers/md/dm-ioctl.c	2003-02-26 16:09:52.000000000 +0000
+++ source/drivers/md/dm-ioctl.c	2003-02-26 16:09:57.000000000 +0000
@@ -1123,17 +1123,17 @@
 	return 0;
 
       failed:
+	devfs_remove(DM_DIR "/control");
+	if (misc_deregister(&_dm_misc) < 0)
+		DMERR("misc_deregister failed for control device");
 	dm_hash_exit();
-	misc_deregister(&_dm_misc);
 	return r;
 }
 
 void dm_interface_exit(void)
 {
-	dm_hash_exit();
-
 	devfs_remove(DM_DIR "/control");
-
 	if (misc_deregister(&_dm_misc) < 0)
 		DMERR("misc_deregister failed for control device");
+	dm_hash_exit();
 }

  parent reply	other threads:[~2003-02-26 17:00 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-26 17:05 device-mapper patchset 2.5.63-dm-1 Joe Thornber
2003-02-26 17:08 ` [PATCH 1/8] dm: ioctl interface wasn't dropping a table reference Joe Thornber
2003-02-26 17:08 ` [PATCH 2/8] dm: __LOW macro fix no. 1 Joe Thornber
2003-02-26 17:09 ` [PATCH 3/8] dm: prevent possible buffer overflow in ioctl interface Joe Thornber
2003-02-26 21:04   ` Horst von Brand
2003-02-27 14:20     ` Kevin Corry
2003-02-27 14:36       ` Kevin Corry
2003-02-27 16:25         ` Roland Dreier
2003-02-27 16:34           ` Kevin Corry
2003-02-27 22:05           ` Kevin Corry
2003-02-26 17:10 ` Joe Thornber [this message]
2003-02-26 17:11 ` [PATCH 5/8] dm: bug in error path for unknown target type Joe Thornber
2003-02-26 17:11 ` [PATCH 6/8] dm: allow slashes in dm device names Joe Thornber
2003-02-26 17:38   ` Greg KH
2003-02-26 18:17     ` Kevin Corry
2003-02-26 18:20       ` Greg KH
2003-02-26 17:12 ` [PATCH 7/8] dm: __LOW macro fix no. 2 Joe Thornber
2003-02-26 18:14   ` Greg KH
2003-02-27  8:55     ` Joe Thornber
2003-02-27  9:55     ` Joe Thornber
2003-02-27 16:17       ` Horst von Brand
2003-02-27 16:33         ` Joe Thornber
2003-02-27 17:47       ` Greg KH
2003-02-27  9:34   ` Jakob Oestergaard
2003-02-27 10:01     ` Joe Thornber
2003-02-27 12:55       ` Jakob Oestergaard
2003-02-26 17:13 ` [PATCH 8/8] dm: return correct error codes from dm_table_add_target() Joe Thornber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030226171018.GD8369@fib011235813.fsnet.co.uk \
    --to=joe@fib011235813.fsnet.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®