From: _N3X_ <n3x@coders.eu.org>
To: linux-kernel@vger.kernel.org
Subject: serial_cs with devfs
Date: Thu, 27 Feb 2003 08:34:33 +0100 [thread overview]
Message-ID: <20030227073433.GA20856@unreal.coders.eu.org> (raw)
in serial_cs.c there is a hardcoded device name in the code, stating
ttySx, that's not the right thing with devfs..
here's a patch of my own (should work also on the latest prepatch),
just to show the problem, i think that the defines around it could be
more carefully chosen, but what's the deal.. have a nice day.
_N3X_ <n3x@coders.eu.org>
diff -ru linux-2.4.19/drivers/char/pcmcia/serial_cs.c linux-2.4.19-fix/drivers/char/pcmcia/serial_cs.c
--- linux-2.4.19/drivers/char/pcmcia/serial_cs.c 2001-12-21 18:41:54.000000000 +0100
+++ linux-2.4.19-fix/drivers/char/pcmcia/serial_cs.c 2002-11-06 10:14:07.000000000 +0100
@@ -256,7 +256,11 @@
}
info->line[info->ndev] = line;
+#ifdef CONFIG_DEVFS_FS
+ sprintf(info->node[info->ndev].dev_name, "tts/%d", line);
+#else
sprintf(info->node[info->ndev].dev_name, "ttyS%d", line);
+#endif /* CONFIG_DEVFS_FS */
info->node[info->ndev].major = TTY_MAJOR;
info->node[info->ndev].minor = 0x40+line;
if (info->ndev > 0)
next reply other threads:[~2003-02-27 7:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-27 7:34 _N3X_ [this message]
2003-02-27 7:42 ` Zwane Mwaikambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030227073433.GA20856@unreal.coders.eu.org \
--to=n3x@coders.eu.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®