From: Andrew Morton <akpm@digeo.com>
To: maneesh@in.ibm.com
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org, zilvinas@gemtek.lt
Subject: Re: kernel Ooops (2.5.63 bk latest)
Date: Fri, 28 Feb 2003 01:39:43 -0800 [thread overview]
Message-ID: <20030228013943.025774b0.akpm@digeo.com> (raw)
In-Reply-To: <20030228091535.GE11135@in.ibm.com>
Maneesh Soni <maneesh@in.ibm.com> wrote:
>
> ref is taken in d_validate, which is called before using the smbfs cached
> dentry. It is this ref which is taken back in smb_readdir().
hmm, thinking about this a bit more...
It appears that d_validate's role in life is to take some random pointer
which the caller thinks might be a dentry and to verify that it is indeed
still a valid dentry (or a totally new dentry at the same address!). If
so, pin that dentry and tell the user.
Perhaps the dentry's address was received across the network, although it
doesn't look that way.
In which case passing in a might-be pointer to a zero-ref dentry is
appropriate and your patch is OK. One would need some understanding of ncpfs
and smbfs to say for sure.
prev parent reply other threads:[~2003-02-28 9:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-26 11:37 Zilvinas Valinskas
2003-02-28 7:09 ` Maneesh Soni
2003-02-28 7:34 ` Andrew Morton
2003-02-28 9:15 ` Maneesh Soni
2003-02-28 9:39 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030228013943.025774b0.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maneesh@in.ibm.com \
--cc=torvalds@transmeta.com \
--cc=zilvinas@gemtek.lt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®