mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Wolfgang Mües" <wolfgang@iksw-muees.de>
To: Adrian Bunk <bunk@fs.tum.de>, Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: lkml <linux-kernel@vger.kernel.org>, greg@kroah.com
Subject: Re: [patch] 2.4.21-pre5: fix Auerswald compile
Date: Fri, 28 Feb 2003 08:47:41 +0100	[thread overview]
Message-ID: <200302280847.41981.wolfgang@iksw-muees.de> (raw)
In-Reply-To: <20030227232612.GV7685@fs.tum.de>

Hello Adrian,

On Friday 28 February 2003 00:26, Adrian Bunk wrote:

> auerdev_table and auerdev_table_mutex are static in auermain.c but used
> from auerchar.c. The following patch makes them non-static:

You are right. This is a leftover from the old days where auermain and
auerchar function were both in auermain.c.

I wonder why I never get this error? Are you using a newer toolchain?
My gcc is version 2.95.3.

Greg, would you apply this patch?

best regards
Wolfgang Mües

>
> --- linux-2.4.21-pre5-full/drivers/usb/auermain.c.old	2003-02-28
> 00:15:45.000000000 +0100 +++
> linux-2.4.21-pre5-full/drivers/usb/auermain.c	2003-02-28 00:20:49.000000000
> +0100 @@ -66,10 +66,10 @@
>  extern devfs_handle_t usb_devfs_handle;
>
>  /* array of pointers to our devices that are currently connected */
> -static struct auerswald *auerdev_table[AUER_MAX_DEVICES];
> +struct auerswald *auerdev_table[AUER_MAX_DEVICES];
>
>  /* lock to protect the auerdev_table structure */
> -static struct semaphore auerdev_table_mutex;
> +struct semaphore auerdev_table_mutex;
>
>  /*-------------------------------------------------------------------*/
>  /* Forwards */
>
>
> cu
> Adrian


  reply	other threads:[~2003-02-28  7:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-27  6:14 Linux 2.4.21-pre5 Marcelo Tosatti
2003-02-27  8:24 ` Christoph Hellwig
2003-02-27  8:32 ` Adrian Bunk
2003-02-27 12:40   ` Ben Collins
2003-02-27 19:22     ` ajoshi
2003-02-27 19:35       ` Ben Collins
2003-03-11 23:39         ` Marcelo Tosatti
2003-02-27  8:53 ` Christoph Hellwig
2003-02-27  9:39 ` Ben Lau
2003-02-27 10:19   ` Simon Oosthoek
2003-02-27 10:48     ` Benjamin Herrenschmidt
2003-02-27 11:43       ` Simon Oosthoek
2003-02-28  5:46       ` Ben Lau
2003-02-27 23:26 ` [patch] 2.4.21-pre5: fix Auerswald compile Adrian Bunk
2003-02-28  7:47   ` Wolfgang Mües [this message]
2003-03-05 22:02   ` Greg KH
2003-03-07  2:47 ` Linux 2.4.21-pre5 J.A. Magallon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200302280847.41981.wolfgang@iksw-muees.de \
    --to=wolfgang@iksw-muees.de \
    --cc=bunk@fs.tum.de \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®