From: Pete Zaitcev <zaitcev@redhat.com>
To: dsaxena@mvista.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: Proposal: Eliminate GFP_DMA
Date: Fri, 28 Feb 2003 15:51:23 -0500 [thread overview]
Message-ID: <200302282051.h1SKpNm32220@devserv.devel.redhat.com> (raw)
In-Reply-To: <mailman.1046456425.7772.linux-kernel2news@redhat.com>
> This discussion raises an issue that I've been meaning to bring up for a bit.
> Currently, the DMA-API is defined as returning a cpu physical address [1],
> but should the API be redefined as returning an address which is valid on
> the bus which the device sits on? [...]
> dma_addr_t
> dma_map_single(struct device *dev, void *cpu_addr, size_t size,
> enum dma_data_direction direction)
> dma_addr_t
> pci_map_single(struct device *dev, void *cpu_addr, size_t size,
> int direction)
>
> Maps a piece of processor virtual memory so it can be accessed by the
> device and returns the _physical_ handle of the memory.
That's only a sloppy documentation, obviously it returns a bus
address, not a physical address. Simply the x86 graduate who wrote
it cannot see the difference, that's all. Pay it no mind and
implement it properly, that means copy it from sparc64.
Who reads documentation anyway when we have the source?
-- Pete
next prev parent reply other threads:[~2003-02-28 20:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20030228064631.G23865@parcelfarce.linux.theplanet.co.uk.suse.lists.linux.kernel>
2003-02-28 8:56 ` Andi Kleen
2003-02-28 14:12 ` Matthew Wilcox
2003-02-28 15:24 ` Alan Cox
2003-02-28 14:34 ` Matthew Wilcox
2003-02-28 15:55 ` Alan Cox
2003-02-28 14:56 ` Andi Kleen
2003-02-28 15:25 ` Jeff Garzik
2003-02-28 15:30 ` Andi Kleen
2003-02-28 15:34 ` Martin J. Bligh
2003-02-28 15:49 ` Eli Carter
2003-02-28 16:03 ` Russell King
2003-02-28 16:45 ` Alan Cox
2003-02-28 15:31 ` Arjan van de Ven
2003-03-04 17:56 ` Rogier Wolff
2003-03-04 23:09 ` Alan Cox
2003-03-05 7:43 ` Rogier Wolff
2003-03-05 13:53 ` Alan Cox
2003-02-28 15:44 ` Dmitry A. Fedorov
2003-02-28 15:58 ` Jeff Garzik
2003-02-28 18:17 ` Deepak Saxena
2003-02-28 18:27 ` Deepak Saxena
2003-02-28 19:52 ` Russell King
[not found] ` <mailman.1046456425.7772.linux-kernel2news@redhat.com>
2003-02-28 20:51 ` Pete Zaitcev [this message]
2003-02-28 22:11 ` Russell King
2003-02-28 16:05 ` Russell King
2003-02-28 17:27 ` Ivan Kokshaysky
2003-02-28 17:45 ` Alan Cox
2003-02-28 6:46 Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200302282051.h1SKpNm32220@devserv.devel.redhat.com \
--to=zaitcev@redhat.com \
--cc=dsaxena@mvista.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®