From: Andrew Morton <akpm@digeo.com>
To: Dawson Engler <engler@csl.stanford.edu>
Cc: linux-kernel@vger.kernel.org, mc@cs.stanford.edu
Subject: Re: [CHECKER] a few race conditions
Date: Fri, 28 Feb 2003 21:33:20 -0800 [thread overview]
Message-ID: <20030228213320.6d2da213.akpm@digeo.com> (raw)
In-Reply-To: <200303010455.h214tpO11048@csl.stanford.edu>
Dawson Engler <engler@csl.stanford.edu> wrote:
>
> BUG FALSE pair: lock=<dcache_lock:spinlock_t:0>, var=<struct inode.i_dentry>
> 2 errors out of 5 uses:
> /u2/engler/mc/oses/linux/linux-2.5.53/fs/dcache.c:284:d_prune_aliases: ERROR: var <struct inode.i_dentry> not protected by <dcache_lock:spinlock_t:0>(pop=5, s=3) [locked=0]
>
> i think this actually is a race: other places check it.
>
> void d_prune_aliases(struct inode *inode)
> {
> struct list_head *tmp, *head = &inode->i_dentry;
> restart:
> spin_lock(&dcache_lock);
This is OK. Local variable `head' is being set up to point at a member
inside the inode, but we're not dereferencing that pointer outside the lock.
The address of inode->i_dentry is constant across this function.
prev parent reply other threads:[~2003-03-01 5:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-01 4:55 Dawson Engler
2003-03-01 5:33 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030228213320.6d2da213.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=engler@csl.stanford.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=mc@cs.stanford.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®