From: Andrew Morton <akpm@digeo.com>
To: Dawson Engler <engler@csl.stanford.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [CHECKER] potential deadlocks
Date: Sun, 2 Mar 2003 21:25:00 -0800 [thread overview]
Message-ID: <20030302212500.72fe9b87.akpm@digeo.com> (raw)
In-Reply-To: <200303030335.h233ZTt07857@csl.stanford.edu>
Dawson Engler <engler@csl.stanford.edu> wrote:
>
> Any feedback on the results would be great. My understanding of linux's
> sprawling locking rules is less than impressive.
We would be impressed if it wasn't :)
> Also, if there are
> known deadlocks, let me know and I can make sure we're finding them.
There are some real ones there. The ones surrounding lock_kernel() and
semaphores are false positives.
lock_kernel() is special, in that the lock is dropped when the caller
performs a voluntary context switch. So there are no ordering requirements
between lock_kernel and the sleeping locks down(), down_read(), down_write().
lock_kernel() inside a spinlock is not necessarily a bug, but almost always
is. It should be warned about.
next prev parent reply other threads:[~2003-03-03 5:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-03 3:35 Dawson Engler
2003-03-03 5:25 ` Andrew Morton [this message]
2003-03-03 6:05 ` Dawson Engler
2003-03-03 6:18 ` Andrew Morton
2003-03-03 6:25 ` Dawson Engler
2003-03-03 9:45 ` Nikita Danilov
2003-03-04 7:52 ` Dawson Engler
2003-03-07 11:24 ` Nikita Danilov
2003-03-03 13:56 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030302212500.72fe9b87.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=engler@csl.stanford.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®