From: Amit Shah <shahamit@gmx.net>
To: Matthew Wilcox <willy@debian.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] taskqueue to workqueue update for riscom8 driver
Date: Mon, 3 Mar 2003 13:05:22 +0530 [thread overview]
Message-ID: <200303031305.22854.shahamit@gmx.net> (raw)
In-Reply-To: <20030302163427.C7301@parcelfarce.linux.theplanet.co.uk>
On Sunday 02 Mar 2003 22:04, Matthew Wilcox wrote:
> So it only compiles on UP. Not terribly interesting.
>
> BTW, I wouldn't necessarily expect it to work. Work queues run in
> process context; the code you replaced ran in bottom half context.
> If you're going to do this kind of lame hack, it should be converted
> to a tasklet, not a work queue.
A simple grep for cli() in drivers/char reveals that many of those drivers
still use cli(), which means even they haven't yet been converted to the new
framework.
As for the patch, other drivers, like cyclades, for example, too have been
modified in the same manner.... on digging, I found that the original patch
that converted the taskqueues to workqueues had also done it the same way.
Amit.
--
Amit Shah
http://amitshah.nav.to/
The most exciting phrase to hear in science, the one that heralds new
discoveries, is not "Eureka!" (I found it!) but "That's funny ..."
-- Isaac Asimov
next prev parent reply other threads:[~2003-03-03 7:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-02 4:38 Matthew Wilcox
2003-03-02 12:21 ` Amit Shah
2003-03-02 16:34 ` Matthew Wilcox
2003-03-03 7:35 ` Amit Shah [this message]
2003-03-03 8:12 ` Matthew Wilcox
-- strict thread matches above, loose matches on Subject: below --
2003-03-01 17:46 Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200303031305.22854.shahamit@gmx.net \
--to=shahamit@gmx.net \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®