From: Andrew Morton <akpm@digeo.com>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: reducing stack usage in v4l?
Date: Tue, 4 Mar 2003 21:43:26 -0800 [thread overview]
Message-ID: <20030304214326.7fe7a7ba.akpm@digeo.com> (raw)
In-Reply-To: <32833.4.64.238.61.1046841945.squirrel@www.osdl.org>
"Randy.Dunlap" <rddunlap@osdl.org> wrote:
>
> Hi,
>
> I was looking at stack usage in drivers/media/video/v4l1-compat.c::
> v4l_compat_translate_ioctl(). It's 0x924 bytes on my peecee.
>
> It's fairly straightforward to change the stack space to
> kmalloc() space, but some of these functions (ioctls) are
> speed-critical, so I was wondering if the changes should still
> be done, or done only in some cases and not others, or wait
> until an oops is reported here....
>
Well the function is doing a memset() of 2k's worth of memory already,
so it presumably doesn't care much.
Your kmalloc will be a small cost compared with that.
next prev parent reply other threads:[~2003-03-05 5:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-05 5:25 Randy.Dunlap
2003-03-05 5:43 ` Andrew Morton [this message]
2003-03-05 9:15 ` Gerd Knorr
2003-03-05 9:35 ` Russell King
2003-03-05 15:34 ` Randy.Dunlap
2003-03-05 21:40 ` Jörn Engel
2003-03-11 4:27 ` Randy.Dunlap
2003-03-11 9:19 ` Gerd Knorr
2003-03-11 16:29 ` Alan Cox
2003-03-11 15:36 ` Daniel Jacobowitz
2003-03-05 11:50 ` mdew
2003-03-05 12:28 ` Gerd Knorr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030304214326.7fe7a7ba.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®