mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Pavel Machek <pavel@ucw.cz>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: sys32_ioctl -> compat_ioctl -- generic
Date: Wed, 5 Mar 2003 10:28:49 +1100	[thread overview]
Message-ID: <20030305102849.61469d19.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20030303232122.GA24018@elf.ucw.cz>

Hi Pavel,

On Tue, 4 Mar 2003 00:21:22 +0100 Pavel Machek <pavel@ucw.cz> wrote:
>
> This is generic part of sys32_ioctl -> compat_ioctl. Please apply,

Thanks for this - you saved me a headache :-)

Some comments:

> --- clean/kernel/compat.c	2003-03-03 23:39:39.000000000 +0100
> +++ linux/kernel/compat.c	2003-02-20 10:48:21.000000000 +0100

All this really belongs in fs/compat.c ...

One thing that Linus (and I) wanted from the compatability layer is
to try to keep all 32 bit assumptions out of the generic code - I
understand that this my not be possible, but we would like to try.

So maybe you could start by changing ioctl32 to compat_ioctl everywhere -
I know that this is just cosmetic, but it gives the better impression of
what the code is about ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

  reply	other threads:[~2003-03-04 23:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-03 23:21 Pavel Machek
2003-03-04 23:28 ` Stephen Rothwell [this message]
2003-03-05 21:43   ` Pavel Machek
2003-03-04 23:36 ` Stephen Rothwell
2003-03-06 23:37   ` Pavel Machek
2003-03-09 22:44     ` Stephen Rothwell
2003-03-10 11:28     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030305102849.61469d19.sfr@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®