From: Sam Ravnborg <sam@ravnborg.org>
To: Joern Engel <joern@wohnheim.fh-wedel.de>
Cc: Sam Ravnborg <sam@ravnborg.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add checkstack Makefile target
Date: Wed, 5 Mar 2003 20:15:16 +0100 [thread overview]
Message-ID: <20030305191516.GB1841@mars.ravnborg.org> (raw)
In-Reply-To: <20030305145149.GA7509@wohnheim.fh-wedel.de>
On Wed, Mar 05, 2003 at 03:51:49PM +0100, J??rn Engel wrote:
> > Since the above is now architecture independent, better locate it in
> > the top level Makefile.
>
> But the perl script itself breaks for anything but i386 and ppc at the
> moment, so I keep the changes in the arch Makefiles. Ultimately this
> should support all architectures and go to the top level, though.
There is no reason to put this in the arch specific makefiles.
You error out in a nice way in checkstack.pl anyway.
And architecture specific requirements shall be kept on a minimum.
Realise that the changes get even smaller, and only one file needs
to be touched to support a new architecture.
> +checkstack: vmlinux ***FORCE***
> + $(OBJDUMP) -d vmlinux | \
> + $(PERL) scripts/checkstack.pl $(ARCH)
You need FORCE to make sure the rule is actually executed.
And we have a variable that points to perl, use that one.
Sam
next prev parent reply other threads:[~2003-03-05 19:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-03 21:16 Jörn Engel
2003-03-04 7:03 ` Muli Ben-Yehuda
2003-03-04 7:24 ` Jörn Engel
2003-03-04 10:21 ` Jörn Engel
2003-03-04 10:57 ` Jörn Engel
2003-03-04 19:08 ` Sam Ravnborg
2003-03-05 14:51 ` Jörn Engel
2003-03-05 17:14 ` Jörn Engel
2003-03-05 19:15 ` Sam Ravnborg [this message]
2003-03-05 19:54 ` Jörn Engel
2003-03-11 15:36 ` =?unknown-8bit?Q?J=F6rn?= Engel
2003-03-23 19:08 ` Sam Ravnborg
2003-03-25 13:49 ` Jörn Engel
2003-03-25 23:53 ` Juan Quintela
[not found] <20030305172012$3eb0@gated-at.bofh.it>
[not found] ` <20030305172012$0dea@gated-at.bofh.it>
[not found] ` <20030305172012$0ad6@gated-at.bofh.it>
[not found] ` <20030305172012$4a05@gated-at.bofh.it>
[not found] ` <20030305172012$03b3@gated-at.bofh.it>
[not found] ` <20030305172012$525f@gated-at.bofh.it>
[not found] ` <20030305172012$698e@gated-at.bofh.it>
[not found] ` <20030305172012$38f6@gated-at.bofh.it>
2003-03-06 1:50 ` Arnd Bergmann
2003-03-06 10:51 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030305191516.GB1841@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®