From: Andrew Morton <akpm@digeo.com>
To: "Martin J. Bligh" <mbligh@aracnet.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Warning: dev (pts(136,0)) tty->count(5) != #fd's(4) in tty_open
Date: Tue, 11 Mar 2003 16:21:53 -0800 [thread overview]
Message-ID: <20030311162153.493a305e.akpm@digeo.com> (raw)
In-Reply-To: <45750000.1047426594@flay>
"Martin J. Bligh" <mbligh@aracnet.com> wrote:
>
> I'm getting lots of these messages whilst running big SDET runs on
> an 16-way machine ... anyone recognize them?
> (64-bk3 + a few patches).
>
> dev (pts(136,0)) tty->count(4) != #fd's(3) in release_dev
The file_list_lock patches affect this. Do you have those applied?
If so, and if it is repeatable, this might help. (Unlikely, but it might).
diff -puN drivers/char/tty_io.c~tty_files-fixes drivers/char/tty_io.c
--- 25/drivers/char/tty_io.c~tty_files-fixes 2003-03-09 23:15:15.000000000 -0800
+++ 25-akpm/drivers/char/tty_io.c 2003-03-09 23:15:58.000000000 -0800
@@ -1037,7 +1037,9 @@ static void release_mem(struct tty_struc
}
o_tty->magic = 0;
(*o_tty->driver.refcount)--;
+ file_list_lock();
list_del(&o_tty->tty_files);
+ file_list_unlock();
free_tty_struct(o_tty);
}
@@ -1049,7 +1051,9 @@ static void release_mem(struct tty_struc
}
tty->magic = 0;
(*tty->driver.refcount)--;
+ file_list_lock();
list_del(&tty->tty_files);
+ file_list_unlock();
module_put(tty->driver.owner);
free_tty_struct(tty);
}
_
next prev parent reply other threads:[~2003-03-12 0:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-11 23:49 Martin J. Bligh
2003-03-12 0:21 ` Andrew Morton [this message]
2003-03-12 0:29 ` Martin J. Bligh
2003-03-12 1:30 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030311162153.493a305e.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®