mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: jak@rudolph.ccur.com (Joe Korty)
To: trond.myklebust@fys.uio.no
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] 2.4.20-rc3 change broke NFS
Date: Tue, 11 Mar 2003 18:19:03 -0500 (EST)	[thread overview]
Message-ID: <200303112319.XAA15215@rudolph.ccur.com> (raw)
In-Reply-To: <15982.23313.285256.769067@charged.uio.no> from "Trond Myklebust" at Mar 11, 2003 10:54:25 PM

> You are actually probably hitting a hole in the file. If the client
> has written beyond the eof, but not yet transmitted the data to the
> server, then you would indeed probably see an EIO.
> 
> Your fix is probably correct, but could you just cross-check by seeing
> if the appended patch also fixes the problem?



Hi Trond,
Your fix to nfs_readpage_result worked.  There may be a small hole
remaining, which the following closes.  This also worked.

- if (data->res.eof || page_index(page) <= inode->i_size >> PAGE_CACHE_SHIFT)
+ if (data->res.eof || page_index(page) < PAGE_CACHE_ALIGN(inode->i_size) >> PAGE_CACHE_SHIFT)

Thanks for your help,
(I'll leave it to you to submit the patch you think best to Marcello and/or Linus).       
Joe

  reply	other threads:[~2003-03-11 23:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-11 19:26 Joe Korty
2003-03-11 21:54 ` Trond Myklebust
2003-03-11 23:19   ` Joe Korty [this message]
2003-03-11 23:29     ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200303112319.XAA15215@rudolph.ccur.com \
    --to=jak@rudolph.ccur.com \
    --cc=joe.korty@ccur.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®