From: Jens Axboe <axboe@suse.de>
To: Andrew Morton <akpm@digeo.com>
Cc: Luben Tuikov <luben@splentec.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix kernel oops in generic_unplug_device() for md
Date: Wed, 12 Mar 2003 08:11:46 +0100 [thread overview]
Message-ID: <20030312071146.GG1295@suse.de> (raw)
In-Reply-To: <20030311172815.46ac305d.akpm@digeo.com>
On Tue, Mar 11 2003, Andrew Morton wrote:
> Luben Tuikov <luben@splentec.com> wrote:
> >
> > The following patch fixes a kernel oops when doing
> > blk_unplug_work() (oopses in generic_unplug_device()) for md.
> >
> > The oops and the original report are here:
> > http://MARC.10East.com/?l=linux-kernel&m=104706400705154&w=2
> >
>
> Yup, is a bug. I received the below fix from Neil today which looks
> simpler.
>
> diff -puN drivers/block/ll_rw_blk.c~auto-unplugging-fix drivers/block/ll_rw_blk.c
> --- 25/drivers/block/ll_rw_blk.c~auto-unplugging-fix Tue Mar 11 15:04:00 2003
> +++ 25-akpm/drivers/block/ll_rw_blk.c Tue Mar 11 15:04:00 2003
> @@ -1004,7 +1004,8 @@ void generic_unplug_device(void *data)
>
> static void blk_unplug_work(void *data)
> {
> - generic_unplug_device(data);
> + request_queue_t *q = data;
> + q->unplug_fn(q);
> }
this is the correct fix
--
Jens Axboe
prev parent reply other threads:[~2003-03-12 7:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-12 1:20 Luben Tuikov
2003-03-12 1:28 ` Andrew Morton
2003-03-12 7:11 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030312071146.GG1295@suse.de \
--to=axboe@suse.de \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luben@splentec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®