mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joern Engel <joern@wohnheim.fh-wedel.de>
To: Dave Jones <davej@codemonkey.org.uk>,
	Grzegorz Jaskiewicz <gj@pointblue.com.pl>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: mb800 watchdog driver
Date: Thu, 13 Mar 2003 16:36:53 +0100	[thread overview]
Message-ID: <20030313153653.GA21104@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <20030313161033.GA8751@suse.de>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=unknown-8bit, Size: 683 bytes --]

On Thu, 13 March 2003 15:10:33 -0100, Dave Jones wrote:
> 
> in fact, these printk's should probably be something like dprintk's
> with dprintk being defined at the top of source like..
> 
> #define DEBUG
> #ifndef DEBUG
> # define dprintk(format, args...)
> #else
> # define dprintk(format, args...) printk(KERN_DEBUG "mb8wdog:", ## args)
                                                               ^^
> #endif

You might want to put an additional whitespace at the indicated
position, that works around a gcc 2.x bug.

Jörn

-- 
Mundie uses a textbook tactic of manipulation: start with some
reasonable talk, and lead the audience to an unreasonable conclusion.
-- Bruce Perens

  reply	other threads:[~2003-03-13 15:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-13  8:11 Grzegorz Jaskiewicz
2003-03-13 16:10 ` Dave Jones
2003-03-13 15:36   ` Joern Engel [this message]
2003-03-13 16:19   ` Christoph Hellwig
2003-03-13 22:52 Grzegorz Jaskiewicz
2004-01-28 15:23 mb800 WatchDog driver Grzegorz Jaskiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030313153653.GA21104@wohnheim.fh-wedel.de \
    --to=joern@wohnheim.fh-wedel.de \
    --cc=davej@codemonkey.org.uk \
    --cc=gj@pointblue.com.pl \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®