From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Joern Engel <joern@wohnheim.fh-wedel.de>
Cc: braam@clusterfs.com, alan@lxorguk.ukuu.org.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix stack usage in fs/intermezzo/journal.c
Date: Fri, 14 Mar 2003 08:45:36 -0800 [thread overview]
Message-ID: <20030314084536.522ad81c.rddunlap@osdl.org> (raw)
In-Reply-To: <20030314164445.GC23161@wohnheim.fh-wedel.de>
On Fri, 14 Mar 2003 17:44:45 +0100 Joern Engel <joern@wohnheim.fh-wedel.de> wrote:
| On Fri, 14 March 2003 08:09:30 -0800, Randy.Dunlap wrote:
| >
| > I guess one of us needs some guidance here.
| > I thought that sizeof(*buf) == 1 here, not 4096. Anybody?
| > I don't see how sizeof() can determine the kmalloc-ed size,
| > so I would use BUF_SIZE instead, with
| > #define BUF_SIZE 4096
|
| I'd love to say you're wrong, but you're not. New patch is below.
| FUNCTION_NAME_BUFSIZE should have less name collision than BUF_SIZE,
| but someone who knows intermezzo better than me might find a much
| nicer name.
If you are concerned about namespace & collisions, you can
#undef BUF_SIZE
after each function.
--
~Randy
next prev parent reply other threads:[~2003-03-14 16:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-14 15:53 Joern Engel
2003-03-14 16:09 ` Randy.Dunlap
2003-03-14 16:44 ` Joern Engel
2003-03-14 16:45 ` Randy.Dunlap [this message]
2003-03-14 16:55 ` Joern Engel
2003-03-14 16:54 ` Randy.Dunlap
2003-03-14 18:21 ` Peter Braam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030314084536.522ad81c.rddunlap@osdl.org \
--to=rddunlap@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=braam@clusterfs.com \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®