From: bert hubert <ahu@ds9a.nl>
To: dan carpenter <d_carpenter@sbcglobal.net>
Cc: Zwane Mwaikambo <zwane@holomorphy.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
wrlk@riede.org
Subject: Re: Any hope for ide-scsi (error handling)?
Date: Sat, 15 Mar 2003 21:25:09 +0100 [thread overview]
Message-ID: <20030315202509.GA4374@outpost.ds9a.nl> (raw)
In-Reply-To: <200303152012.h2FKCulK283698@pimout2-ext.prodigy.net>
On Sat, Mar 15, 2003 at 03:52:21AM +0100, dan carpenter wrote:
> > >
> > > 887 spin_lock_irqsave(&ide_lock, flags);
> > > 888 while (HWGROUP(drive)->handler) {
> > > 889 HWGROUP(drive)->handler = NULL;
> > > 890 schedule_timeout(1);
> > > 891 }
> > >
> > > Here is at least one bad call to schedule() in
> > > static int idescsi_reset (Scsi_Cmnd *cmd)
> >
> > Apart from the schedule with the ide_lock held, what is that code actually
> > doing?
> >
> > Zwane
>
> Hm... Good question. I have no idea what the while loop is for.
A construct like this was suggested for use in swsusp too to make sure that
only *one* request is outstanding for a controler. This was also mentioned
to be the unclean way and that there are taskfile interfaces which are
cleaner.
Bert.
--
http://www.PowerDNS.com Open source, database driven DNS Software
http://lartc.org Linux Advanced Routing & Traffic Control HOWTO
http://netherlabs.nl Consulting
next prev parent reply other threads:[~2003-03-15 20:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-15 18:55 Zwane Mwaikambo
2003-03-15 2:05 ` dan carpenter
2003-03-15 19:53 ` Zwane Mwaikambo
2003-03-15 2:52 ` dan carpenter
2003-03-15 20:23 ` Zwane Mwaikambo
2003-03-15 21:01 ` Willem Riede
2003-03-15 4:43 ` dan carpenter
2003-03-15 21:11 ` Zwane Mwaikambo
2003-03-15 22:29 ` Willem Riede
2003-03-16 1:23 ` Alan Cox
2003-03-16 0:55 ` Willem Riede
2003-03-16 21:41 ` Alan Cox
2003-03-15 20:25 ` bert hubert [this message]
2003-03-15 20:41 ` Zwane Mwaikambo
2003-03-15 20:55 ` Zwane Mwaikambo
2003-03-16 1:05 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030315202509.GA4374@outpost.ds9a.nl \
--to=ahu@ds9a.nl \
--cc=d_carpenter@sbcglobal.net \
--cc=linux-kernel@vger.kernel.org \
--cc=wrlk@riede.org \
--cc=zwane@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®