mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@digeo.com>
To: Nigel Cunningham <ncunningham@clear.net.nz>
Cc: pavel@ucw.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Don't refill pcp lists during SWSUSP.
Date: Mon, 17 Mar 2003 16:05:56 -0800	[thread overview]
Message-ID: <20030317160556.4efc880f.akpm@digeo.com> (raw)
In-Reply-To: <1047945372.1714.19.camel@laptop-linux.cunninghams>

Nigel Cunningham <ncunningham@clear.net.nz> wrote:
>
> +extern unsigned int suspend_task;


Please do:

#ifdef CONFIG_SOFTWARE_SUSPEND
unsigned int suspend_task;
#else
#define suspend_task 0
#endif

so the compiler can remove the few fast-path instructions which you have
added.

>  	
> +	suspend_task = current->pid;
> +

Zero is a valid PID (the idle task...).  It might be clearer to make
suspend_task a task_struct*.


  reply	other threads:[~2003-03-18  0:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-17 23:56 Nigel Cunningham
2003-03-18  0:05 ` Andrew Morton [this message]
2003-03-18  5:27   ` Nigel Cunningham
     [not found]     ` <20030317222018.5c7f7a56.akpm@digeo.com>
2003-03-18  6:35       ` Nigel Cunningham
2003-03-18  6:40   ` Nigel Cunningham
2003-03-18  8:18 ` Pavel Machek
2003-03-18 10:06   ` Nigel Cunningham
2003-03-18 16:58     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030317160556.4efc880f.akpm@digeo.com \
    --to=akpm@digeo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ncunningham@clear.net.nz \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®