From: "Philippe De Muyter" <phdm@macqel.be>
To: Dave Jones <davej@codemonkey.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: sundance DFE-580TX DL10050B patch
Date: Mon, 17 Mar 2003 18:40:36 +0100 (CET) [thread overview]
Message-ID: <200303171740.h2HHebY01003@mail.macqel.be> (raw)
In-Reply-To: <20030317172416.GA3366@suse.de> from Dave Jones at "Mar 17, 2003 04:24:21 pm"
Dave Jones wrote :
> On Mon, Mar 17, 2003 at 02:56:09PM +0100, Philippe De Muyter wrote:
>
> > + writew((dev->dev_addr[i + 1] << 8) + dev->dev_addr[i],
>
> Don't you want to OR those together instead of add them ?
>
> Dave
>
You're right.
Here it is :
--- drivers/net/sundance.c Mon Mar 17 13:15:48 2003
+++ drivers/net/sundance.c Thu Feb 13 11:56:43 2003
@@ -853,8 +853,10 @@
writel(np->rx_ring_dma, ioaddr + RxListPtr);
/* The Tx list pointer is written as packets are queued. */
- for (i = 0; i < 6; i++)
- writeb(dev->dev_addr[i], ioaddr + StationAddr + i);
+ /* Station address must be written as 16 bit words with the DL10050B chip. */
+ for (i = 0; i < 6; i += 2)
+ writew((dev->dev_addr[i + 1] << 8) | dev->dev_addr[i],
+ ioaddr + StationAddr + i);
/* Initialize other registers. */
writew(dev->mtu + 14, ioaddr + MaxFrameSize);
next prev parent reply other threads:[~2003-03-17 17:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-17 13:56 Philippe De Muyter
2003-03-17 17:24 ` Dave Jones
2003-03-17 17:40 ` Philippe De Muyter [this message]
2003-03-17 17:49 ` Jeff Garzik
2003-03-18 14:27 ` Philippe De Muyter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200303171740.h2HHebY01003@mail.macqel.be \
--to=phdm@macqel.be \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®