From: Jeff Garzik <jgarzik@pobox.com>
To: David Brownell <david-b@pacbell.net>
Cc: Greg KH <greg@kroah.com>,
usb-devel <linux-usb-devel@lists.sourceforge.net>,
linux-kernel@vger.kernel.org,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Subject: Re: [patch 2.5.65] ehci-hcd, don't use PCI MWI
Date: Wed, 19 Mar 2003 10:34:21 -0500 [thread overview]
Message-ID: <20030319153421.GA26181@gtf.org> (raw)
In-Reply-To: <3E788B06.4090302@pacbell.net>
On Wed, Mar 19, 2003 at 07:21:42AM -0800, David Brownell wrote:
> Hi,
>
> Some users have been sending init logs for Athlon kernels that
> include PCI warning messages about the PCI cache line size
> getting set incorrectly ... where the kernel thinks that the
> right value is 16 bytes. Since 64 bytes is the right number,
> it's dangerous to enable MWI on such systems.
>
> This patch stops trying to use MWI; it's a workaround for the
> misbehavior of that PCI cacheline-setting code. Please apply
> to 2.5 and 2.4 trees.
Please don't -- Ivan has a patch for this, let's get that in instead.
We all acknowledge your patch is a workaround, but this sort of fix does
not belong in the mainstream kernel. We want to fix it The Right
Way(tm), once. And since a patch already exists for this...
We need to get IvanK's extended-save-restore-state patch in, too.
Ivan, would you be up for a repost on lkml?
Jeff
next prev parent reply other threads:[~2003-03-19 15:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-19 15:21 David Brownell
2003-03-19 15:34 ` Jeff Garzik [this message]
2003-03-19 15:53 ` David Brownell
2003-03-19 16:34 ` Ivan Kokshaysky
2003-03-19 18:12 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030319153421.GA26181@gtf.org \
--to=jgarzik@pobox.com \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®