From: Bob Miller <rem@osdl.org>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: linux-kernel@vger.kernel.org, linux-sh@m17n.org, gniibe@m17n.org,
kkojima@rr.iij4u.or.jp
Subject: Re: [PATCH] reduce stack usage in arch/sh/kernel/pci-sh7751
Date: Thu, 20 Mar 2003 14:06:51 -0800 [thread overview]
Message-ID: <20030320220651.GB16501@doc.pdx.osdl.net> (raw)
In-Reply-To: <20030320215910.GA16501@doc.pdx.osdl.net>
On Thu, Mar 20, 2003 at 01:59:11PM -0800, Bob Miller wrote:
> On Thu, Mar 20, 2003 at 12:08:33PM -0800, Randy.Dunlap wrote:
> > +
> > + bus = kmalloc(sizeof(*bus), GFP_ATOMIC);
> > + dev = kmalloc(sizeof(*dev), GFP_ATOMIC);
> > + if (!bus || !dev) {
> > + printk(KERN_ERR "Out of memory in %s\n", __FUNCTION__);
> > + goto exit;
> > + }
> > +
> If the kmalloc() for bus succeeds but for dev fails this will leak the
> memory given to bus.
>
That's a goto, not a return... Never mind.
--
Bob Miller Email: rem@osdl.org
Open Source Development Lab Phone: 503.626.2455 Ext. 17
prev parent reply other threads:[~2003-03-20 21:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-20 20:08 Randy.Dunlap
2003-03-20 21:59 ` Bob Miller
2003-03-20 22:06 ` Bob Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030320220651.GB16501@doc.pdx.osdl.net \
--to=rem@osdl.org \
--cc=gniibe@m17n.org \
--cc=kkojima@rr.iij4u.or.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@m17n.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®