From: Arnd Bergmann <arnd@bergmann-dalldorf.de>
To: Brian Gerst <bgerst@didntduck.org>,
linux-kernel@vger.kernel.org,
Manfred Spraul <manfred@colorfullife.com>
Subject: Re: [PATCH] slab.c cleanup
Date: Sun, 23 Mar 2003 22:24:10 +0100 [thread overview]
Message-ID: <200303232124.h2NLOqQJ020547@post.webmailer.de> (raw)
In-Reply-To: <20030323211014$2f0c@gated-at.bofh.it>
Brian Gerst wrote:
> Manfred Spraul wrote:
>>
>> No, the patch is a bad thing: It means that everyone who does
>> kmalloc(32,) now allocates 128 bytes, i.e. 3/4 wasted. IMHO not acceptable.
>
> Perhaps, but it currently is already allocating 128 bytes for smaller
> caches, because the cache is created with SLAB_HWCACHE_ALIGN. So we
> ended up with redundantly sized caches.
Doesn't this code in kmem_cache_create() handle this already?
> if (flags & SLAB_HWCACHE_ALIGN) {
> /* Need to adjust size so that objs are cache aligned. */
> /* Small obj size, can get at least two per cache line. */
> while (size < align/2)
> align /= 2;
> size = (size+align-1)&(~(align-1));
> }
Arnd <><
next parent reply other threads:[~2003-03-23 21:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20030323211010$1215@gated-at.bofh.it>
[not found] ` <20030323211014$2f0c@gated-at.bofh.it>
2003-03-23 21:24 ` Arnd Bergmann [this message]
[not found] <20030323191010$7678@gated-at.bofh.it>
2003-03-23 21:11 ` Arnd Bergmann
2003-03-23 20:59 Manfred Spraul
2003-03-23 21:07 ` Brian Gerst
2003-03-23 21:20 ` Manfred Spraul
2003-03-23 21:51 ` Brian Gerst
-- strict thread matches above, loose matches on Subject: below --
2003-03-23 18:58 Brian Gerst
2003-03-23 19:12 ` Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200303232124.h2NLOqQJ020547@post.webmailer.de \
--to=arnd@bergmann-dalldorf.de \
--cc=bgerst@didntduck.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®