From: davej@codemonkey.org.uk
To: jgarzik@pobox.com
Cc: linux-kernel@vger.kernel.org
Subject: finish init_etherdev conversion for gt96100eth
Date: Mon, 24 Mar 2003 16:41:48 +0000 [thread overview]
Message-ID: <200303241642.h2OGg135008232@deviant.impure.org.uk> (raw)
- No need to alloc dev->priv (due to init_etherdev usage)
- No need to kfree dev->priv (kfree'd with (dev) already)
diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/net/gt96100eth.c linux-2.5/drivers/net/gt96100eth.c
--- bk-linus/drivers/net/gt96100eth.c 2003-03-08 09:57:15.000000000 +0000
+++ linux-2.5/drivers/net/gt96100eth.c 2003-01-06 19:00:54.000000000 +0000
@@ -758,19 +758,6 @@ gt96100_probe1(int port_num)
goto free_region;
}
- /* Initialize our private structure. */
- if (dev->priv == NULL) {
-
- gp = (struct gt96100_private *)kmalloc(sizeof(*gp),
- GFP_KERNEL);
- if (gp == NULL) {
- retval = -ENOMEM;
- goto free_region;
- }
-
- dev->priv = gp;
- }
-
gp = dev->priv;
memset(gp, 0, sizeof(*gp)); // clear it
@@ -854,8 +841,6 @@ gt96100_probe1(int port_num)
free_region:
release_region(gtif->iobase, GT96100_ETH_IO_SIZE);
unregister_netdev(dev);
- if (dev->priv != NULL)
- kfree (dev->priv);
kfree (dev);
err("%s failed. Returns %d\n", __FUNCTION__, retval);
return retval;
@@ -1601,8 +1586,6 @@ static void gt96100_cleanup_module(void)
(struct gt96100_private *)gtif->dev->priv;
release_region(gtif->iobase, gp->io_size);
unregister_netdev(gtif->dev);
- if (gtif->dev->priv != NULL)
- kfree (gtif->dev->priv);
kfree (gtif->dev);
}
}
reply other threads:[~2003-03-24 16:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200303241642.h2OGg135008232@deviant.impure.org.uk \
--to=davej@codemonkey.org.uk \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®