From: Jeff Garzik <jgarzik@pobox.com>
To: davej@codemonkey.org.uk
Cc: linux-kernel@vger.kernel.org
Subject: Re: stray 2.4 tcp fix.
Date: Mon, 24 Mar 2003 12:55:54 -0500 [thread overview]
Message-ID: <20030324175554.GA5119@gtf.org> (raw)
In-Reply-To: <200303241642.h2OGgC35008344@deviant.impure.org.uk>
On Mon, Mar 24, 2003 at 04:42:00PM +0000, davej@codemonkey.org.uk wrote:
> Sent to davem and netdev already, and was met with silence..
>
> diff -urpN --exclude-from=/home/davej/.exclude bk-linus/net/ipv4/tcp.c linux-2.5/net/ipv4/tcp.c
> --- bk-linus/net/ipv4/tcp.c 2003-03-21 12:53:31.000000000 +0000
> +++ linux-2.5/net/ipv4/tcp.c 2003-03-21 13:45:21.000000000 +0000
> @@ -1189,7 +1189,8 @@ new_segment:
>
> from += copy;
> copied += copy;
> - seglen -= copy;
> + if ((seglen -= copy) == 0 && iovlen == 0)
> + goto out;
What's the purpose of combining a statement and a test?
Simply adding a test would be more clear.
Jeff
next prev parent reply other threads:[~2003-03-24 17:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-24 16:42 davej
2003-03-24 17:55 ` Jeff Garzik [this message]
2003-03-25 6:43 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030324175554.GA5119@gtf.org \
--to=jgarzik@pobox.com \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®