mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: Dave Jones <davej@codemonkey.org.uk>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [2.5 patch] fix sound/oss/mad16.c compile
Date: Wed, 26 Mar 2003 12:00:01 +0100	[thread overview]
Message-ID: <20030326110001.GJ24744@fs.tum.de> (raw)
In-Reply-To: <Pine.LNX.4.44.0303241524050.1741-100000@penguin.transmeta.com>

On Mon, Mar 24, 2003 at 03:26:47PM -0800, Linus Torvalds wrote:
>...
> Summary of changes from v2.5.65 to v2.5.66
> ============================================
>...
> Dave Jones <davej@codemonkey.org.uk>:
>...
>   o guard mad16 debug macro
>...


This change broke the compilation of sound/oss/mad16.c:

<--  snip  -->

...
  gcc -Wp,-MD,sound/oss/.mad16.o.d -D__KERNEL__ -Iinclude -Wall 
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe 
-mpreferred-stack-boundary=2 -march=k6 -Iinclude/asm-i386/mach-default -nostdinc 
-iwithprefix include    -DKBUILD_BASENAME=mad16 -DKBUILD_MODNAME=mad16 -c -o 
sound/oss/mad16.o sound/oss/mad16.c
...
sound/oss/mad16.c: In function `probe_mad16':
sound/oss/mad16.c:541: syntax error before "else"
sound/oss/mad16.c:604: syntax error before "else"
make[2]: *** [sound/oss/mad16.o] Error 1

<--  snip  -->


The following patch is needed:


--- linux-2.5.66-notfull/sound/oss/mad16.c.old	2003-03-26 11:52:13.000000000 +0100
+++ linux-2.5.66-notfull/sound/oss/mad16.c	2003-03-26 11:55:06.000000000 +0100
@@ -537,7 +537,7 @@
 
 	for (i = 0xf8d; i <= 0xf93; i++) {
 		if (!c924pnp)
-			DDB(printk("port %03x = %02x\n", i, mad_read(i)))
+			DDB(printk("port %03x = %02x\n", i, mad_read(i)));
 		else
 			DDB(printk("port %03x = %02x\n", i-0x80, mad_read(i)));
 	}
@@ -600,7 +600,7 @@
 
 	for (i = 0xf8d; i <= 0xf93; i++) {
 		if (!c924pnp)
-			DDB(printk("port %03x after init = %02x\n", i, mad_read(i)))
+			DDB(printk("port %03x after init = %02x\n", i, mad_read(i)));
 		else
 			DDB(printk("port %03x after init = %02x\n", i-0x80, mad_read(i)));
 	}


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  parent reply	other threads:[~2003-03-26 10:48 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-24 23:26 Linux 2.5.66 Linus Torvalds
2003-03-24 23:35 ` Larry McVoy
2003-03-25  0:14 ` Florin Iucha
2003-03-25  8:05   ` Rolf Eike Beer
2003-03-25  8:29     ` Marco Roeland
2003-03-25  0:16 ` Jeremy Brown
2003-03-25  0:22 ` Udo A. Steinberg
2003-03-25  0:30   ` Greg KH
2003-03-25  1:18     ` Udo A. Steinberg
2003-03-25  1:47       ` Greg KH
2003-03-25  4:18     ` CaT
2003-03-25  4:34       ` Greg KH
2003-03-25  5:56         ` CaT
2003-03-25  6:51           ` Greg KH
2003-03-25  7:22             ` CaT
2003-03-25  7:27               ` Greg KH
2003-03-25  0:53 ` John Cherry
2003-03-25  1:55 ` [REPRODUCABLE BUGS] " Toplica Tanaskovic
2003-03-25  3:19   ` James Simmons
2003-03-25  9:51     ` Toplica Tanaskovic
2003-03-26 20:24       ` James Simmons
2003-03-26 23:49         ` Torrey Hoffman
2003-03-27  0:20           ` James Simmons
2003-03-27  2:27             ` Joshua Kwan
2003-04-02 22:16               ` James Simmons
2003-04-03  1:02                 ` Joshua Kwan
2003-04-03  3:59                   ` James Simmons
2003-03-27 16:05         ` Toplica Tanaskovic
2003-03-26  2:53 ` Paweł Gołaszewski
2003-03-26  3:33   ` James Simmons
2003-03-26 11:00 ` Adrian Bunk [this message]
2003-03-26 11:26 ` 2.5.66: compile problem with snd-ice1724 Adrian Bunk
2003-03-26 12:45 ` [2.5 patch] fix ipmi_devintf.c compilation Adrian Bunk
2003-03-26 14:36   ` Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030326110001.GJ24744@fs.tum.de \
    --to=bunk@fs.tum.de \
    --cc=davej@codemonkey.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®