From: Andrew Morton <akpm@digeo.com>
To: Jochen Hein <jochen@jochen.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.5.66] slab corruption
Date: Wed, 26 Mar 2003 13:30:21 -0800 [thread overview]
Message-ID: <20030326133021.43f75e1c.akpm@digeo.com> (raw)
In-Reply-To: <871y0uhriz.fsf@echidna.jochen.org>
Jochen Hein <jochen@jochen.org> wrote:
>
>
> This is when shutting down. I have the two patches from Jack Simmons
> for the illegal context and the broken cursor applied and nothing
> else.
>
> uhci-hcd 00:07.2: remove, state 3
> usb usb1: USB disconnect, address 1
There's some nastiness in the USB disconnect code. Does David Brownell's
patch help?
--- 1.15/drivers/usb/core/urb.c Thu Mar 13 10:45:40 2003
+++ edited/drivers/usb/core/urb.c Thu Mar 20 11:17:55 2003
@@ -384,11 +384,11 @@
/* FIXME
* We should not care about the state here, but the host controllers
* die a horrible death if we unlink a urb for a device that has been
- * physically removed.
+ * physically removed. (after driver->disconnect returns...)
*/
if (urb &&
urb->dev &&
- (urb->dev->state >= USB_STATE_DEFAULT) &&
+ // (urb->dev->state >= USB_STATE_DEFAULT) &&
urb->dev->bus &&
urb->dev->bus->op)
return urb->dev->bus->op->unlink_urb(urb);
next prev parent reply other threads:[~2003-03-26 21:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-26 19:11 Jochen Hein
2003-03-26 21:30 ` Andrew Morton [this message]
2003-03-27 18:38 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030326133021.43f75e1c.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=jochen@jochen.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®