From: Rusty Russell <rusty@rustcorp.com.au>
To: John Levon <levon@movementarian.org>
Cc: oprofile-list@lists.sf.net, torvalds@transmeta.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Module load notification take 3
Date: Thu, 27 Mar 2003 13:20:23 +1100 [thread overview]
Message-ID: <20030327041148.0A4A12C054@lists.samba.org> (raw)
In-Reply-To: Your message of "Tue, 25 Mar 2003 11:41:52 -0000." <20030325114152.GB30581@compsoc.man.ac.uk>
In message <20030325114152.GB30581@compsoc.man.ac.uk> you write:
> On Tue, Mar 25, 2003 at 05:32:33PM +1100, Rusty Russell wrote:
>
> > > Implement a module load notifier for the benefit of OProfile, tested
> > > with .66 on UP.
> >
> > Minor change to make unregister_module_notifier return void.
>
> The -ENOENT return is there for a reason.
What reason? I just grepped 2.5.66-bk2, and *noone* uses the return
value, not even to BUG() (you have to grep for all the wrappers for
notifier_call_unregister, too).
That's because everyone realizes that the return value is useless.
> If you don't want it, then you should remove it from
> notifier_call_register too.
(I assume you mean notifier_call_unregister). Yes, but that's another
battle.
Meanwhile, at least I'm not adding to the problem.
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2003-03-27 4:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-25 2:03 John Levon
2003-03-25 2:13 ` [PATCH 2/2] " John Levon
2003-03-25 6:32 ` [PATCH 1/2] " Rusty Russell
2003-03-25 11:41 ` John Levon
2003-03-27 2:20 ` Rusty Russell [this message]
2003-03-27 4:17 ` John Levon
2003-03-27 5:26 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030327041148.0A4A12C054@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=levon@movementarian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oprofile-list@lists.sf.net \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®