mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mark M. Hoffman" <mhoffman@lightlink.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Jan Dittmer <j.dittmer@portrix.net>,
	azarah@gentoo.org, greg@kroah.com, mds@paradyne.com,
	linux-kernel@vger.kernel.org, linux@brodo.de,
	sensors@Stimpy.netroedge.com
Subject: Re: lm sensors sysfs file structure
Date: Thu, 27 Mar 2003 12:16:38 -0500	[thread overview]
Message-ID: <20030327171638.GA23888@earth.solarsys.private> (raw)
In-Reply-To: <20030327143140.0428fcd7.khali@linux-fr.org>

* Jean Delvare <khali@linux-fr.org> [2003-03-27 14:31:40 +0100]:
> > Ah, and I don't want to do small corrections like 1 or 2 percent up or
> > or down, but things like this for lm80:
> >      compute in0 (24/14.7 + 1) * @ ,       @ / (24/14.7 + 1)
> >      compute in2 (22.1/30 + 1) * @ ,       @ / (22.1/30 + 1)
> >      compute in3 (2.8/1.9) * @,            @ * 1.9/2.8
> >      compute in4 (160/30.1 + 1) * @,       @ / (160/30.1 + 1)
> > 
> > These differ a lot. And as stated in the sensors.conf seem to be from 
> > the datasheet of the lm80 and not mainboard specific.
> 
> They may be mainboard specific. The formulae rely on *suggested*
> resistor values, which the integrators may or may not follow. There
> definitely is a need for userspace conversion. Libsensors needs to be
> tunable by the user.
> 
> I don't know about the kernel conversion Jan is talking about (never
> coded a sensor driver myself), so I can't talk about this half, but I'm
> pretty sure you shouldn't even think of moving all conversions into
> kernel space.
> 
> Mark, Phil, maybe you could explain the reasons better than I would?

I'm not the Mark to which Jean refers, but anyway...  he is correct.
The sensor chip cannot read temperatures directly, only voltage.  The
conversion from degress C to V is dependent on the mainboard for the
reasons Jean mentions.

But also, the chip driver cannot read voltage directly, only bits in a
register.  *That* conversion is *not* mainboard dependent; it is
sensor chip specific.

Even when the subject in question is voltage (e.g. power supply +12V),
there is mainboard dependent nonsense between the "real value" and what
is presented at the pin of the sensor chip.

So there is a legitimate need for two conversions.  IMHO, the 
mainboard dependent one *must* be done in userspace (as Jean says).
But the conversion of raw register values to volts should happen in
the kernel; fixed point maths are sufficient for that.

(Yes I'm simplifying; external sensors can present data to sensors
chips in other electrical formats, e.g. PWM.  Same argument applies.)

Regards,

-- 
Mark M. Hoffman
mhoffman@lightlink.com


  reply	other threads:[~2003-03-27 17:08 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-25  8:53 i2c driver changes for 2.5.66; adding w83781d support Martin Schlemmer
2003-03-25 17:56 ` Greg KH
2003-03-26 19:04   ` w83781d i2c driver updated for 2.5.66 (without sysfs support) Martin Schlemmer
2003-03-26 19:40     ` Jan Dittmer
2003-03-26 19:54       ` Martin Schlemmer
2003-03-26 20:26       ` Greg KH
2003-03-26 20:43         ` Christoph Hellwig
2003-03-26 21:23           ` Greg KH
2003-03-26 22:26         ` Mark Studebaker
2003-03-26 22:52           ` lm sensors sysfs file structure Greg KH
2003-03-27 10:46             ` Jan Dittmer
2003-03-27 10:50               ` Martin Schlemmer
2003-03-27 12:27                 ` Jan Dittmer
2003-03-27 12:33                   ` Martin Schlemmer
2003-03-27 13:05                     ` Jan Dittmer
2003-03-27 13:31                       ` Jean Delvare
2003-03-27 17:16                         ` Mark M. Hoffman [this message]
2003-03-27 17:25               ` Greg KH
2003-03-27 18:06                 ` Jan Dittmer
2003-03-27 18:13                   ` Greg KH
2003-03-30 19:23                 ` Pavel Machek
2003-04-01  6:44                   ` Greg KH
2003-04-01 20:22                     ` Pavel Machek
2003-04-01 23:27                     ` Dave Jones
2003-04-03  0:28                       ` Greg KH
2003-04-03 10:49                         ` Dave Jones
2003-04-03 18:43                           ` Dominik Brodowski
2003-03-27 18:40             ` Jan Dittmer
2003-03-27 18:52               ` Greg KH
2003-03-27 18:17                 ` Patrick Mochel
2003-03-27 18:57                 ` Jan Dittmer
2003-03-27 19:15                 ` Martin Schlemmer
2003-03-27 19:25                   ` Greg KH
2003-03-27 19:42             ` Greg KH
2003-03-27 20:32               ` Jan Dittmer
2003-03-27 21:53                 ` Greg KH
2003-03-27 22:23                   ` Mark M. Hoffman
2003-03-28  6:05                   ` Martin Schlemmer
2003-03-28 18:34             ` Pavel Machek
2003-03-26 20:29     ` w83781d i2c driver updated for 2.5.66 (without sysfs support) Greg KH
2003-03-26 23:34       ` Martin Schlemmer
2003-03-26 23:46         ` Greg KH
2003-03-30 12:47           ` [PATCH-2.5] w83781d i2c driver updated for 2.5.66-bk4 (with sysfs support, empty tree) Martin Schlemmer
2003-04-02 22:22             ` Greg KH
2003-03-27 23:00 lm sensors sysfs file structure Albert Cahalan
2003-03-27 23:10 ` Greg KH
2003-03-28  7:21   ` Martin Schlemmer
2003-03-28  7:40     ` Greg KH
2003-04-03 21:19 Grover, Andrew
2003-04-14 15:16 ` Patrick Mochel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030327171638.GA23888@earth.solarsys.private \
    --to=mhoffman@lightlink.com \
    --cc=azarah@gentoo.org \
    --cc=greg@kroah.com \
    --cc=j.dittmer@portrix.net \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@brodo.de \
    --cc=mds@paradyne.com \
    --cc=sensors@Stimpy.netroedge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®