mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: Stelian Pop <stelian@popies.net>,
	Marcelo Tosatti <marcelo@conectiva.com.br>,
	Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.kernel.org
Subject: [patch] fix .text.exit error in sonypi.c
Date: Thu, 27 Mar 2003 23:13:31 +0100	[thread overview]
Message-ID: <20030327221331.GB24744@fs.tum.de> (raw)

The following .text.exit error is present in 2.4.1-pre6 (it seems to be 
in 2.5.66, too):

<--  snip  -->

...
drivers/char/char.o(.text+0x9a891): In function `sonypi_pm_callback':
: undefined reference to `local symbols in discarded section .text.exit'
drivers/char/char.o(.text+0x9a898): In function `sonypi_pm_callback':
: undefined reference to `local symbols in discarded section .text.exit'
...

<--  snip  -->


In drivers/char/sonypi.c the __devexit funcitions sonypi_type1_dis and 
sonypi_type2_dis are called from the non-__devexit function 
sonypi_pm_callback.


The following patch removes the __devexit from these two functions:


--- linux-2.4.21-pre6-full-nohotplug/drivers/char/sonypi.c.old	2003-03-27 22:07:23.000000000 +0100
+++ linux-2.4.21-pre6-full-nohotplug/drivers/char/sonypi.c	2003-03-27 22:09:05.000000000 +0100
@@ -162,7 +162,7 @@
 }
 
 /* Disables the device - this comes from the AML code in the ACPI bios */
-static void __devexit sonypi_type1_dis(void) {
+static void sonypi_type1_dis(void) {
 	u32 v;
 
 	pci_read_config_dword(sonypi_device.dev, SONYPI_G10A, &v);
@@ -174,7 +174,7 @@
 	outl(v, SONYPI_IRQ_PORT);
 }
 
-static void __devexit sonypi_type2_dis(void) {
+static void sonypi_type2_dis(void) {
 	if (ec_write(SONYPI_SHIB, 0))
 		printk(KERN_WARNING "ec_write failed\n");
 	if (ec_write(SONYPI_SLOB, 0))



I've tested the compilation with 2.4.21-pre6.


Please apply
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


             reply	other threads:[~2003-03-27 22:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-27 22:13 Adrian Bunk [this message]
2003-03-30 14:50 ` Stelian Pop

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030327221331.GB24744@fs.tum.de \
    --to=bunk@fs.tum.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=stelian@popies.net \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®