From: Adrian Bunk <bunk@fs.tum.de>
To: Randolph Chung <tausq@debian.org>,
Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: linux-kernel@vger.kernel.org
Subject: [2.4 patch] fix ad1889.c .text.exit error
Date: Thu, 27 Mar 2003 23:14:18 +0100 [thread overview]
Message-ID: <20030327221418.GF24744@fs.tum.de> (raw)
In 2,4,21-pre6 the function ad1889_remove in drivers/sound/ad1889.c is
__devexit but the pointer to it doesn't use __devexit_p resulting in a
.text.exit error if !CONFIG_HOTPLUG.
The following patch is needed:
--- linux-2.4.21-pre6-full-nohotplug/drivers/sound/ad1889.c.old 2003-03-27 22:40:12.000000000 +0100
+++ linux-2.4.21-pre6-full-nohotplug/drivers/sound/ad1889.c 2003-03-27 22:42:39.000000000 +0100
@@ -1059,7 +1059,7 @@
name: DEVNAME,
id_table: ad1889_id_tbl,
probe: ad1889_probe,
- remove: ad1889_remove,
+ remove: __devexit_p(ad1889_remove),
};
static int __init ad1889_init_module(void)
I've tested the compilation with 2.4.21-pre6.
Please apply
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
reply other threads:[~2003-03-27 22:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030327221418.GF24744@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=tausq@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®