On Sun, Mar 23, 2003 at 07:11:03PM +0100, Peter Waechtler wrote:
> Am Fre, 2003-03-21 um 21.10 schrieb Adrian Bunk:
> > The following patch fixes the problem for me, please check whether it's 
> > correct:
> > 
> > --- linux-2.5.65-full/sound/oss/ics2101.c.old	2003-03-21 19:13:23.000000000 +0100
> > +++ linux-2.5.65-full/sound/oss/ics2101.c	2003-03-21 19:13:53.000000000 +0100
> > @@ -29,7 +29,7 @@
> >  
> >  extern int     *gus_osp;
> >  extern int      gus_base;
> > -extern spinlock_t lock;
> > +spinlock_t      lock = SPIN_LOCK_UNLOCKED;
> >  static int      volumes[ICS_MIXDEVS];
> >  static int      left_fix[ICS_MIXDEVS] =
> >  {1, 1, 1, 2, 1, 2};
> > 
> 
> With that patch you do not protect anything.
> The write_mix function should share the spinlock used in the 
> interrupt handler.

This sounds reasonable (I have to admit I didn't look deeply into the 
code).

> Do you compile for Uniprocessor? Can you post the relevant config?
> I don't get a link error with SMP.

Yes, I'm compiling Uniprocessor. The .config is attached.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed