Re: genksyms crashes on drivers/char/joystick/pcigame.c

[Adam Lackorzynski <adam@os.inf.tu-dresden.de>]

On Wed Apr 02, 2003 at 21:17:11 +1000, Keith Owens wrote:
> On Tue, 1 Apr 2003 17:19:18 +0200, 
> Adam Lackorzynski <adam@os.inf.tu-dresden.de> wrote:
> >when genksyms is used on drivers/char/joystick/pcigame.c during "make
> >dep" it segfaults.
> 
> genksyms assumes and requires valid C code as input.  genksyms does not
> attempt to validate the source, that is the job of gcc.  If gcc barfs
> on the code, then do not attempt to run it through genksyms.  This
> looks like a chicken and egg problem but is not, compile with
> MODVERSIONS=n to verify that new code is valid before building with
> MODVERSIONS=y.  To put it another way, do not run modversions on test
> kernels.

I don't understand a vanilla 2.4.20 kernel as a "test kernel". This
segfault happens everytime a "make dep" with modversions and without
these joystick options is done and that's probably not too uncommon.
There's just no error message indicating that it's faulting.
Changing include/linux/pci_gameport.h prevents genksyms from segfaulting and
produces output, I'm not sure if this has other side effects.


For 2.4.20:
--- include/linux/pci_gameport.h.orig   2003-04-02 14:00:46.000000000 +0200
+++ include/linux/pci_gameport.h        2003-04-02 14:02:01.000000000 +0200
@@ -31,9 +31,6 @@
 #if defined(CONFIG_INPUT_PCIGAME) || defined(CONFIG_INPUT_PCIGAME_MODULE)
 extern struct pcigame *pcigame_attach(struct pci_dev *dev, int type);
 extern void pcigame_detach(struct pcigame *game);
-#else
-#define pcigame_attach(a,b)    NULL
-#define pcigame_detach(a)
 #endif
 
 #endif





Adam
-- 
Adam                 adam@os.inf.tu-dresden.de
  Lackorzynski         http://os.inf.tu-dresden.de/~adam/