From: Andrew Morton <akpm@digeo.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: jjs <jjs@tmsusa.com>, "Grover, Andrew" <andrew.grover@intel.com>,
linux-kernel@vger.kernel.org
Subject: [patch] acpi compile fix
Date: Thu, 3 Apr 2003 13:05:05 -0800 [thread overview]
Message-ID: <20030403130505.199294c7.akpm@digeo.com> (raw)
ACPI is performing a spin_lock() on a `void *'. That's OK when spin_lock is
implemented via an inline function. But when it is implemented via macros
(eg, with spinlock debugging enabled) we get:
drivers/acpi/osl.c:739: warning: dereferencing `void *' pointer
drivers/acpi/osl.c:739: request for member `owner' in something not a structure or union
So cast it to the right type.
diff -puN drivers/acpi/osl.c~acpi-spinlock-casts drivers/acpi/osl.c
--- 25/drivers/acpi/osl.c~acpi-spinlock-casts Thu Apr 3 13:00:54 2003
+++ 25-akpm/drivers/acpi/osl.c Thu Apr 3 13:01:25 2003
@@ -736,7 +736,7 @@ acpi_os_acquire_lock (
if (flags & ACPI_NOT_ISR)
ACPI_DISABLE_IRQS();
- spin_lock(handle);
+ spin_lock((spinlock_t *)handle);
return_VOID;
}
@@ -755,7 +755,7 @@ acpi_os_release_lock (
ACPI_DEBUG_PRINT ((ACPI_DB_MUTEX, "Releasing spinlock[%p] from %s level\n", handle,
((flags & ACPI_NOT_ISR) ? "non-interrupt" : "interrupt")));
- spin_unlock(handle);
+ spin_unlock((spinlock_t *)handle);
if (flags & ACPI_NOT_ISR)
ACPI_ENABLE_IRQS();
_
next reply other threads:[~2003-04-03 20:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-03 21:05 Andrew Morton [this message]
2003-04-04 6:48 ` J Sloan
2003-04-04 12:18 ` Dave Jones
2003-04-04 19:57 ` Andrew Morton
2003-04-04 20:27 ` Dave Jones
2003-04-04 21:41 Grover, Andrew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030403130505.199294c7.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=andrew.grover@intel.com \
--cc=jjs@tmsusa.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®